Re: [Intel-wired-lan] [PATCH net v3 0/4] ice: Fixes for double vlan promiscuous mode

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 8/10/2022 7:21 AM, Grzegorz Siwik wrote:
> This series fixes known issues related to double vlan promiscuous mode.
> When at least two interfaces are bonded and a bridge is enabled on the
> bond, an error can occur when the bridge is removed and re-added. The
> reason for the error is because promiscuous mode was not fully cleared from
> the VLAN VSI in the hardware.
> Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode.
> This fix is needed because the driver could set promiscuous mode
> when it still has not cleared properly.
> If the requested promiscuous mode setting already exists,
> an -EEXIST error message would be printed.
> This is incorrect because promiscuous mode is
> either on/off and shouldn't print an error when the requested
> configuration is already set.
> Avoid enabling or disabling vlan 0 when trying to set promiscuous
> vlan mode if double vlan mode is enabled. This fix is needed
> because the driver tries to add the vlan 0 filter twice (once for
> inner and once for outer) when double VLAN mode is enabled.

This doesn't apply. Did you rebase?

> ---
>   v2: Fixed error message when setting same promiscuous mode
> ---

nit/suggestion:
There doesn't need to be a '---' between every entry. Save some space :)

>   v3: Fixed style issues, changed to return directly.
> ---
> Benjamin Mikailenko (1):
>    ice: Ignore error message when setting same promiscuous mode
> 
> Grzegorz Siwik (3):
>    ice: Fix double VLAN error when entering promisc mode
>    ice: Ignore ERR_ALREADY_EXISTS when setting promisc mode

The title needs to be updated too. s/ERR_ALREADY_EXISTS/EEXIST

>    ice: Fix clearing of promisc mode with bridge over bond
> 
>   drivers/net/ethernet/intel/ice/ice_fltr.c   |  8 ++++----
>   drivers/net/ethernet/intel/ice/ice_lib.c    |  8 +++++++-
>   drivers/net/ethernet/intel/ice/ice_main.c   | 13 ++++++++++++-
>   drivers/net/ethernet/intel/ice/ice_switch.c |  9 ++++++++-
>   4 files changed, 31 insertions(+), 7 deletions(-)
> 
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan