From: "Linux regression tracking (Thorsten Leemhuis)" <regressions@leemhuis.info>
To: Lin Ma <linma@zju.edu.cn>,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, richardcochran@gmail.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com
Cc: pmenzel@molgen.mpg.de, vinschen@redhat.com,
intel-wired-lan@lists.osuosl.org, regressions@lists.linux.dev,
stable@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] igb: revert rtnl_lock() that causes deadlock
Date: Tue, 7 Mar 2023 14:17:56 +0100 [thread overview]
Message-ID: <f3531259-626c-3182-3dba-7118d0c1445c@leemhuis.info> (raw)
In-Reply-To: <20230307130547.31446-1-linma@zju.edu.cn>
On 07.03.23 14:05, Lin Ma wrote:
> The commit 6faee3d4ee8b ("igb: Add lock to avoid data race") adds
> rtnl_lock to eliminate a false data race shown below
>
> (FREE from device detaching) | (USE from netdev core)
> igb_remove | igb_ndo_get_vf_config
> igb_disable_sriov | vf >= adapter->vfs_allocated_count?
> kfree(adapter->vf_data) |
> adapter->vfs_allocated_count = 0 |
> | memcpy(... adapter->vf_data[vf]
>
> [...]
> CC: stable@vger.kernel.org
> Fixes: 6faee3d4ee8b ("igb: Add lock to avoid data race")
> Reported-by: Corinna <vinschen@redhat.com>
> Link: https://lore.kernel.org/regressions/3ef31c0b-ce40-20d0-7740-5dc0cca278ca@molgen.mpg.de/
FWIW, that afaics should be:
Link:
https://lore.kernel.org/intel-wired-lan/ZAcJvkEPqWeJHO2r@calimero.vinschen.de/
(that's the parent of the mail above)
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
Ciao, Thorsten
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-03-07 13:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 9:54 [Intel-wired-lan] Deadlock since commit 6faee3d4ee8b ("igb: Add lock to avoid data race") Corinna Vinschen
2023-03-07 10:12 ` [Intel-wired-lan] [REGRESSION] " Paul Menzel
2023-03-07 10:19 ` Paul Menzel
2023-03-07 10:36 ` Lin Ma
2023-03-07 12:11 ` Corinna Vinschen
2023-03-07 12:37 ` Lin Ma
2023-03-07 12:55 ` Corinna Vinschen
2023-03-07 11:48 ` Lin Ma
2023-03-07 13:05 ` [Intel-wired-lan] [PATCH] igb: revert rtnl_lock() that causes deadlock Lin Ma
2023-03-07 13:17 ` Linux regression tracking (Thorsten Leemhuis) [this message]
2023-03-07 13:45 ` Corinna Vinschen
2023-03-07 15:29 ` [Intel-wired-lan] [PATCH v2] " Lin Ma
2023-03-07 16:27 ` Corinna Vinschen
2023-03-07 23:22 ` Jacob Keller
2023-03-08 12:04 ` Simon Horman
2023-03-16 9:10 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3531259-626c-3182-3dba-7118d0c1445c@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=regressions@lists.linux.dev \
--cc=richardcochran@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).