intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: <intel-xe@lists.freedesktop.org>
Subject: [Intel-xe] [PATCH 2/2] drm/xe: Dump GuC log on xe_gt_record_default_lrcs failure
Date: Tue, 28 Mar 2023 12:58:22 -0700	[thread overview]
Message-ID: <20230328195822.1941865-3-matthew.brost@intel.com> (raw)
In-Reply-To: <20230328195822.1941865-1-matthew.brost@intel.com>

This will help debug driver load failures.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_uc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 70eabf567156..5b76328fc0af 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -8,6 +8,7 @@
 #include "xe_device.h"
 #include "xe_gt.h"
 #include "xe_guc.h"
+#include "xe_guc_log.h"
 #include "xe_guc_pc.h"
 #include "xe_guc_submit.h"
 #include "xe_huc.h"
@@ -149,8 +150,12 @@ int xe_uc_init_hw(struct xe_uc *uc)
 		return ret;
 
 	ret = xe_gt_record_default_lrcs(uc_to_gt(uc));
-	if (ret)
+	if (ret) {
+		struct drm_printer p = drm_info_printer(uc_to_xe(uc)->drm.dev);
+
+		xe_guc_log_print(&uc->guc.log, &p);
 		return ret;
+	}
 
 	ret = xe_guc_post_load_init(&uc->guc);
 	if (ret)
-- 
2.34.1


  parent reply	other threads:[~2023-03-28 19:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 19:58 [Intel-xe] [PATCH 0/2] Extra debug for driver load issue Matthew Brost
2023-03-28 19:58 ` [Intel-xe] [PATCH 1/2] drm/xe: Better error messages for xe_gt_record_default_lrcs Matthew Brost
2023-03-28 20:14   ` Matt Roper
2023-03-28 20:47   ` Michal Wajdeczko
2023-03-28 19:58 ` Matthew Brost [this message]
2023-03-28 20:00 ` [Intel-xe] ✓ CI.Patch_applied: success for Extra debug for driver load issue Patchwork
2023-03-28 20:01 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-03-28 20:05 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-03-28 20:27 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230328195822.1941865-3-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).