From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: thomas.hellstrom@intel.com, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 2/3] drm/xe/tests: Set correct expectation
Date: Fri, 31 Mar 2023 22:38:58 -0700 [thread overview]
Message-ID: <20230401053858.5p2pttr6hyugdqwj@ldmartin-desk2.lan> (raw)
In-Reply-To: <20230401030300.22568-3-niranjana.vishwanathapura@intel.com>
On Fri, Mar 31, 2023 at 08:02:59PM -0700, Niranjana Vishwanathapura wrote:
>In xe_migrate_sanity_kunit test, use correct expected value from
>xe_migrate_copy() operation.
>
>Reviewed-by: Matthew Brost <matthew.brost@intel.com>
>Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>---
> drivers/gpu/drm/xe/tests/xe_migrate.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c
>index 90f4e1c4f029..862d11b2210f 100644
>--- a/drivers/gpu/drm/xe/tests/xe_migrate.c
>+++ b/drivers/gpu/drm/xe/tests/xe_migrate.c
>@@ -147,6 +147,7 @@ static void test_copy(struct xe_migrate *m, struct xe_bo *bo,
> xe_map_memset(xe, &sysmem->vmap, 0, 0xc0, sysmem->size);
> xe_map_memset(xe, &bo->vmap, 0, 0xd0, bo->size);
>
>+ expected = 0xc0c0c0c0c0c0c0c0;
Fixes: c1a4e05c9aeb ("drm/xe: Stop accepting value in xe_migrate_clear")
as the expected value was not only used for the xe_migrate_clear(), but
also for the xe_migrate_copy.
Lucas De Marchi
> fence = xe_migrate_copy(m, sysmem, sysmem->ttm.resource,
> bo->ttm.resource);
> if (!sanity_fence_failed(xe, fence, big ? "Copying big bo sysmem -> vram" :
>--
>2.21.0.rc0.32.g243a4c7e27
>
next prev parent reply other threads:[~2023-04-01 5:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 3:02 [Intel-xe] [PATCH 0/3] drm/xe: Get xe_migrate_test working Niranjana Vishwanathapura
2023-04-01 3:02 ` [Intel-xe] [PATCH 1/3] drm/xe/tests: Use proper batch base address Niranjana Vishwanathapura
2023-04-01 3:02 ` [Intel-xe] [PATCH 2/3] drm/xe/tests: Set correct expectation Niranjana Vishwanathapura
2023-04-01 5:38 ` Lucas De Marchi [this message]
2023-04-03 18:45 ` Niranjana Vishwanathapura
2023-04-01 3:03 ` [Intel-xe] [PATCH 3/3] drm/xe: Use proper vram offset Niranjana Vishwanathapura
2023-04-01 3:05 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Get xe_migrate_test working (rev2) Patchwork
2023-04-01 3:06 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-04-01 3:10 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-04-01 3:30 ` [Intel-xe] ○ CI.BAT: info " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-03-31 17:09 [Intel-xe] [PATCH 0/3] drm/xe: Get xe_migrate_test working Niranjana Vishwanathapura
2023-03-31 17:09 ` [Intel-xe] [PATCH 2/3] drm/xe/tests: Set correct expectation Niranjana Vishwanathapura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230401053858.5p2pttr6hyugdqwj@ldmartin-desk2.lan \
--to=lucas.demarchi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=niranjana.vishwanathapura@intel.com \
--cc=thomas.hellstrom@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).