intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Tejas Upadhyay <tejas.upadhyay@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Matthew Brost <matthew.brost@intel.com>,
	Tejas Upadhyay <tejas.upadhyay@intel.com>
Subject: [PATCH] drm/xe: skip error capture when exec queue is killed
Date: Thu, 25 Apr 2024 17:59:31 +0530	[thread overview]
Message-ID: <20240425122931.1851837-1-tejas.upadhyay@intel.com> (raw)

When user closes exec queue soon after job submission,
we are generating error coredump. Instead check if
exec queue is killed during job timeout then skip
error coredump capture, just free the job and return
proper scheduler state.

Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 93e1ee183e4a..376a2c04e899 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -971,7 +971,8 @@ guc_exec_queue_timedout_job(struct drm_sched_job *drm_job)
 	 * TDR has fired before free job worker. Common if exec queue
 	 * immediately closed after last fence signaled.
 	 */
-	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &job->fence->flags)) {
+	if (exec_queue_killed(q) || 
+	    test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &job->fence->flags)) {
 		guc_exec_queue_free_job(drm_job);
 
 		return DRM_GPU_SCHED_STAT_NOMINAL;
-- 
2.25.1


             reply	other threads:[~2024-04-25 12:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 12:29 Tejas Upadhyay [this message]
2024-04-25 12:21 ` ✓ CI.Patch_applied: success for drm/xe: skip error capture when exec queue is killed Patchwork
2024-04-25 12:22 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-25 12:23 ` ✓ CI.KUnit: success " Patchwork
2024-04-25 12:34 ` ✓ CI.Build: " Patchwork
2024-04-25 12:37 ` ✓ CI.Hooks: " Patchwork
2024-04-25 12:38 ` ✓ CI.checksparse: " Patchwork
2024-04-25 13:00 ` ✓ CI.BAT: " Patchwork
2024-04-25 16:23 ` [PATCH] " Matthew Brost
2024-04-26 13:46   ` Souza, Jose
2024-04-29 20:32   ` Rodrigo Vivi
2024-04-30  5:19     ` Upadhyay, Tejas
2024-04-26  1:41 ` ✗ CI.FULL: failure for " Patchwork
2024-04-30 15:46 ` [PATCH] " Matthew Brost
2024-04-30 18:49 ` Matthew Brost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240425122931.1851837-1-tejas.upadhyay@intel.com \
    --to=tejas.upadhyay@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).