From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Nirmoy Das" <nirmoy.das@intel.com>,
"Oak Zeng" <oak.zeng@intel.com>,
"José Roberto de Souza" <jose.souza@intel.com>
Subject: [PATCH v4 3/5] drm/xe: Introduce has_device_atomics_on_smem device info
Date: Fri, 26 Apr 2024 00:23:44 +0200 [thread overview]
Message-ID: <20240425222346.13026-4-nirmoy.das@intel.com> (raw)
In-Reply-To: <20240425222346.13026-1-nirmoy.das@intel.com>
Add has_device_atomics_on_smem to specify that a device
supports device atomics on system memory. Currently XE2
supports this so set this for XE2.
v2: Set has_device_atomics_on_smem for all platform but
PVC.
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Oak Zeng <oak.zeng@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/xe/xe_device_types.h | 2 ++
drivers/gpu/drm/xe/xe_pci.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 7cddb00f9c35..0af739981ebf 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -283,6 +283,8 @@ struct xe_device {
u8 skip_guc_pc:1;
/** @info.has_atomic_enable_pte_bit: Device has atomic enable PTE bit */
u8 has_atomic_enable_pte_bit:1;
+ /** @info.has_device_atomics_on_smem: Supports device atomics on SMEM */
+ u8 has_device_atomics_on_smem:1;
#if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
struct {
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 5618318e6f3a..c6e8a264348c 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -632,6 +632,8 @@ static int xe_info_init(struct xe_device *xe,
xe->info.vm_max_level = graphics_desc->vm_max_level;
xe->info.has_asid = graphics_desc->has_asid;
xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
+ if (xe->info.platform != XE_PVC)
+ xe->info.has_device_atomics_on_smem = 1;
xe->info.has_flat_ccs = graphics_desc->has_flat_ccs;
xe->info.has_range_tlb_invalidation = graphics_desc->has_range_tlb_invalidation;
xe->info.has_usm = graphics_desc->has_usm;
--
2.42.0
next prev parent reply other threads:[~2024-04-25 22:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 22:23 [PATCH v4 0/5] Refactor default device atomic settings Nirmoy Das
2024-04-25 22:23 ` [PATCH v4 1/5] drm/xe: Introduce has_atomic_enable_pte_bit device info Nirmoy Das
2024-04-25 22:23 ` [PATCH v4 2/5] drm/xe: Move vm bind bo validation to a helper function Nirmoy Das
2024-04-25 22:23 ` Nirmoy Das [this message]
2024-04-29 20:19 ` [PATCH v4 3/5] drm/xe: Introduce has_device_atomics_on_smem device info Welty, Brian
2024-04-29 20:42 ` Nirmoy Das
2024-04-25 22:23 ` [PATCH v4 4/5] drm/xe: Add function to check if BO has single placement Nirmoy Das
2024-04-25 22:23 ` [PATCH v4 5/5] drm/xe: Refactor default device atomic settings Nirmoy Das
2024-04-29 20:14 ` Welty, Brian
2024-04-29 20:37 ` Nirmoy Das
2024-04-30 16:23 ` Nirmoy Das
2024-04-25 22:49 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-25 22:50 ` ✓ CI.checkpatch: " Patchwork
2024-04-25 22:51 ` ✓ CI.KUnit: " Patchwork
2024-04-25 23:04 ` ✓ CI.Build: " Patchwork
2024-04-25 23:06 ` ✗ CI.Hooks: failure " Patchwork
2024-04-25 23:07 ` ✗ CI.checksparse: warning " Patchwork
2024-04-25 23:30 ` ✗ CI.BAT: failure " Patchwork
2024-04-26 9:06 ` ✓ CI.Patch_applied: success for Refactor default device atomic settings (rev2) Patchwork
2024-04-26 9:06 ` ✓ CI.checkpatch: " Patchwork
2024-04-26 9:07 ` ✓ CI.KUnit: " Patchwork
2024-04-26 9:19 ` ✓ CI.Build: " Patchwork
2024-04-26 9:21 ` ✓ CI.Hooks: " Patchwork
2024-04-26 9:23 ` ✓ CI.checksparse: " Patchwork
2024-04-26 9:58 ` ✗ CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425222346.13026-4-nirmoy.das@intel.com \
--to=nirmoy.das@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=oak.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).