From: Pavel Begunkov <asml.silence@gmail.com>
To: Victor Stewart <v@nametag.social>, Jens Axboe <axboe@kernel.dk>
Cc: io-uring <io-uring@vger.kernel.org>
Subject: Re: io_uring_prep_timeout_update on linked timeouts
Date: Tue, 31 Aug 2021 17:09:53 +0100 [thread overview]
Message-ID: <019fd0c1-a6ac-a4fc-7b6e-b2779b977ca2@gmail.com> (raw)
In-Reply-To: <CAM1kxwgKJYUN=-CGT02oK+gxk_u60DchEAykoSYLbHRXfOz0Yg@mail.gmail.com>
On 8/31/21 12:36 PM, Victor Stewart wrote:
>>> _Not tested_, but something like below should do. will get it
>>> done properly later, but even better if we already have a test
>>> case. Victor?
>
> sorry been traveling! i can extract out a simple test today...
>
>> FWIW, I wrote a simple test case for it, and it seemed to work fine.
>> Nothing fancy, just a piped read that would never finish with a linked
>> timeout (1s), submit, then submit a ltimeout update that changes it to
>> 2s instead. Test runs and update completes first with res == 0 as
>> expected, and 2s later the ltimeout completes with -EALREADY (because
>> the piped read went async) and the piped read gets canceled.
>
> ...unless?
Extra tests are always appreciated, there is never too many of them :)
FWIW, don't see any new related added by Jens (yet?).
--
Pavel Begunkov
next prev parent reply other threads:[~2021-08-31 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 22:43 io_uring_prep_timeout_update on linked timeouts Victor Stewart
2021-08-25 1:27 ` Victor Stewart
2021-08-27 1:40 ` Victor Stewart
2021-08-28 3:22 ` Jens Axboe
2021-08-28 13:39 ` Pavel Begunkov
2021-08-28 13:43 ` Jens Axboe
2021-08-28 21:38 ` Pavel Begunkov
2021-08-29 2:40 ` Jens Axboe
2021-08-31 11:36 ` Victor Stewart
2021-08-31 16:09 ` Pavel Begunkov [this message]
2021-08-31 16:07 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=019fd0c1-a6ac-a4fc-7b6e-b2779b977ca2@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=v@nametag.social \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).