From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B97A5C433DF for ; Sun, 23 Aug 2020 17:39:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85A5420825 for ; Sun, 23 Aug 2020 17:39:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="MvQeZqU/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbgHWRjc (ORCPT ); Sun, 23 Aug 2020 13:39:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727969AbgHWRjb (ORCPT ); Sun, 23 Aug 2020 13:39:31 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A6CFC061574 for ; Sun, 23 Aug 2020 10:39:30 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id g33so3427798pgb.4 for ; Sun, 23 Aug 2020 10:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mY96LIkN1h9fUPTsChLJqQ4p1857Mmj7eT3GfCFBt0g=; b=MvQeZqU/w0RFMTCRx0FxIpQXO/zA+XNIHtyvjxmJRPH3BOpcpHjoG1gP5Kta+Hp1Zu VYACb6bgUApYQVn2NfTvfjzM/0ig/gOL0lfYKwpMNnmaIgOMaBUUvUvly1zNBYhQiSlQ FYKMF8Suxm2h4FBJG4RGPQquflKuOanTTg6P1zmScXQc/f6pINUh40zkxGZWXZ3QnjVZ OL0pagb1lGjoQa0uYoqwt/fhLS4Vim65KqwOcQrNdM6u0j8Yr3nezY3x/6CpNxjfJiy0 /YbFGiiAwfd9UzCDaIRa5JI0VQ9HMB92Jys0SHPlpK9eSBUAOuG3ly63DJDGnSA3O4mz iA/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mY96LIkN1h9fUPTsChLJqQ4p1857Mmj7eT3GfCFBt0g=; b=BhVKKmCm4s8s2qCJxm2iGSaSWsJnFcxr2vnWsJQ0R7Bzb/SkbvjZ6on7krYAVLa5oV L8uUcWBlYwzON8SQujgZiGwWg7ykMJQHSW+1tTjGyEgemELYlDMdaxP/N7wTBXyzAF2Z 0oSvyVYSpNGcA3egtCn50Fk0uUcXBwMpkKIRszPudDpF2WVxmh+uOW6gMVc9a+sSH1Hb rdjHVMmsiyjnFkU72o2kpC7I1bG62bRShkChTVG6g9LghfXH0o4lFFa7B9AAEF6xBjPK sN9yN6Kiw8H3e0P6K733qliZ/QPe6df699nwUxL5dg7gK//SrykiaxdOq2SGv2o2F/v6 ceSw== X-Gm-Message-State: AOAM531UOMzJInRr0g9hTpFOcKdR/AemnQFYYCEmQVYXfJnj8PxltL9r R0Qr68YQVX89c1yhYMQzEz6d8Q== X-Google-Smtp-Source: ABdhPJxwJAmu+XSPeKf7LDKpimGHmBL7tinYSBo63P3vJDPbu5NlkgL4gcoUMVVAayI+sxKkvZcEUw== X-Received: by 2002:a62:7d0b:: with SMTP id y11mr1399116pfc.262.1598204370006; Sun, 23 Aug 2020 10:39:30 -0700 (PDT) Received: from [192.168.1.182] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id y4sm8833195pff.44.2020.08.23.10.39.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Aug 2020 10:39:29 -0700 (PDT) Subject: Re: [PATCH] io-wq: fix hang after cancelling pending work To: Pavel Begunkov , io-uring@vger.kernel.org Cc: stable@vger.kernel.org, Dmitry Shulyak References: From: Jens Axboe Message-ID: <05a99d44-8310-c8b1-b863-5333c94347f4@kernel.dk> Date: Sun, 23 Aug 2020 11:39:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 8/23/20 11:33 AM, Pavel Begunkov wrote: > Don't forget to update wqe->hash_tail after cancelling a pending work. Yep that fixes it, figured it was something related to hash work cancelations. Applied! -- Jens Axboe