From: Jens Axboe <axboe@kernel.dk>
To: Helge Deller <deller@gmx.de>,
io-uring@vger.kernel.org, linux-ia64@vger.kernel.org,
matoro_mailinglist_kernel@matoro.tk,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH][RFC] io_uring: Fix io_uring_mmu_get_unmapped_area() for IA-64
Date: Thu, 20 Jul 2023 16:30:07 -0600 [thread overview]
Message-ID: <0a242157-6dd6-77fd-b218-52e3ba06e450@kernel.dk> (raw)
In-Reply-To: <ZLhTuTPecx2fGuH1@p100>
On 7/19/23 3:20?PM, Helge Deller wrote:
> The io_uring testcase is broken on IA-64 since commit d808459b2e31
> ("io_uring: Adjust mapping wrt architecture aliasing requirements").
>
> The reason is, that this commit introduced an own architecture
> independend get_unmapped_area() search algorithm which doesn't suite the
> memory region requirements for IA-64.
>
> To avoid similar problems in the future it's better to switch back to
> the architecture-provided get_unmapped_area() function and adjust the
> needed input parameters before the call. Additionally
> io_uring_mmu_get_unmapped_area() will now become easier to understand
> and maintain.
>
> This patch has been tested on physical IA-64 and PA-RISC machines,
> without any failures in the io_uring testcases. On PA-RISC the
> LTP mmmap testcases did not report any regressions either.
>
> I don't expect issues for other architectures, but it would be nice if
> this patch could be tested on other machines too.
Any comments from the IA64 folks?
Helge, should this be split into three patches? One for hppa, one for
ia64, and then the io_uring one?
--
Jens Axboe
next prev parent reply other threads:[~2023-07-20 22:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 21:20 [PATCH][RFC] io_uring: Fix io_uring_mmu_get_unmapped_area() for IA-64 Helge Deller
2023-07-20 0:14 ` matoro
2023-07-20 22:30 ` Jens Axboe [this message]
2023-07-20 22:38 ` Helge Deller
2023-07-20 22:39 ` matoro
2023-07-20 22:43 ` Jens Axboe
2023-07-20 22:43 ` Jens Axboe
2023-07-20 22:57 ` Jens Axboe
2023-07-20 23:01 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a242157-6dd6-77fd-b218-52e3ba06e450@kernel.dk \
--to=axboe@kernel.dk \
--cc=deller@gmx.de \
--cc=io-uring@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=matoro_mailinglist_kernel@matoro.tk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).