From: Stefan Metzmacher <metze@samba.org>
To: Forza <forza@tnonline.net>, Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org
Subject: Re: Stack trace with Samba VFS io_uring and large transfers
Date: Wed, 28 Jul 2021 02:16:01 +0200 [thread overview]
Message-ID: <1e437b44-3917-3ea2-3231-f147b6a30ece@samba.org> (raw)
In-Reply-To: <4848096b-7fc8-ba06-1238-849372d3851e@tnonline.net>
Am 24.07.21 um 21:51 schrieb Forza:
>
>
> On 2021-07-24 21:44, Jens Axboe wrote:
>> On 7/24/21 12:23 PM, Forza wrote:
>>> Hi!
>>>
>>> On 2021-07-24 19:04, Jens Axboe wrote:
>>>> I'll see if I can reproduce this. I'm assuming samba is using buffered
>>>> IO, and it looks like it's reading in chunks of 1MB. Hopefully it's
>>>> possible to reproduce without samba with a windows client, as I don't
>>>> have any of those. If synthetic reproducing fails, I can try samba
>>>> with a Linux client.
>>>
>>> I attached the logs from both a Windows 10 client and a Linux client
>>> (kernel 5.11.0).
>>>
>>> https://paste.tnonline.net/files/r4yebSzlGEVD_linux-client.txt
>>>
>>> smbd_smb2_read: fnum 2641229669, file
>>> media/vm/libvirt/images/Mint_Cinnamon.img, length=4194304
>>> offset=736100352 read=4194304
>>> [2021/07/24 17:26:09.120779, 3]
>>> ../../source3/smbd/smb2_read.c:415(smb2_read_complete)
>>> smbd_smb2_read: fnum 2641229669, file
>>> media/vm/libvirt/images/Mint_Cinnamon.img, length=4194304
>>> offset=740294656 read=4194304
>>> [2021/07/24 17:26:09.226593, 3]
>>> ../../source3/smbd/smb2_read.c:415(smb2_read_complete)
>>> smbd_smb2_read: fnum 2641229669, file
>>> media/vm/libvirt/images/Mint_Cinnamon.img, length=4194304
>>> offset=748683264 read=4194304
>>
>> Thanks, this is useful. Before I try and reproduce it, what is the
>> filesystem that is hosting the samba mount?
>>
>
> I am using Btrfs.
>
> My testing was done by exporting the share with
>
> vfs objects = io_uring
> vfs objects = btrfs, io_uring
>
> Same results in both cases. Exporting with "vfs objects = btrfs" (no io_uring) works as expected.
I don't think it makes a difference for the current problem, but I guess you want the following order instead:
vfs objects = io_uring, btrfs
metze
next prev parent reply other threads:[~2021-07-28 0:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 15:46 Stack trace with Samba VFS io_uring and large transfers Forza
2021-07-24 17:04 ` Jens Axboe
2021-07-24 18:23 ` Forza
2021-07-24 19:44 ` Jens Axboe
2021-07-24 19:51 ` Forza
2021-07-26 16:07 ` Jens Axboe
2021-07-26 16:35 ` Jens Axboe
2021-07-28 10:02 ` Forza
2021-07-28 14:35 ` Jens Axboe
2021-07-28 0:16 ` Stefan Metzmacher [this message]
2021-07-28 2:34 ` Jens Axboe
2021-07-28 9:39 ` Forza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e437b44-3917-3ea2-3231-f147b6a30ece@samba.org \
--to=metze@samba.org \
--cc=axboe@kernel.dk \
--cc=forza@tnonline.net \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).