IO-Uring Archive on
 help / color / Atom feed
From: Stefan Metzmacher <>
To: Jens Axboe <>,
Subject: Re: [PATCHSET 0/4] Allow relative lookups
Date: Fri, 7 Feb 2020 23:56:09 +0100
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1.1: Type: text/plain, Size: 1320 bytes --]

Hi Jens,

>> Am 07.02.20 um 16:50 schrieb Jens Axboe:
>>> Due to an oversight on my part, AT_FDCWD lookups only work when the
>>> lookup can be done inline, not async. This patchset rectifies that,
>>> aiming for 5.6 for this one as it would be a shame to have openat etc
>>> without that.
>>> Just 3 small simple patches - grab the task ->fs, add io-wq suppor for
>>> passing it in and setting it, and finally add a ->needs_fs to the opcode
>>> table list of requirements for openat/openat2/statx.
>>> Last patch just ensures we allow AT_FDCWD.
>> Thanks! But IOSQE_FIXED_FILE is still not supported and not rejected at
>> the same time, correct?
> That's in a separate patch:

Do we handle the error path correct?
As far as I can see io_req_set_file() is called before
io_{statx,openat,openat2}_prep() and req->file is already filled.
Maybe a generic way would be better using io_op_defs[op].allow_fixed_file.

In the long run we may want to add support for openat2 with
IOSQE_FIXED_FILE, then Samba could register the share root directory as
fixed file and it could be used for all openat2 calls.
But for now it's fine to just reject it...


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 15:50 Jens Axboe
2020-02-07 15:50 ` [PATCH 1/4] io_uring: grab owning task fs_struct Jens Axboe
2020-02-07 15:50 ` [PATCH 2/4] io-wq: add support for inheriting ->fs Jens Axboe
2020-02-07 15:50 ` [PATCH 3/4] io_uring: add ->needs_fs to the opcode requirements table Jens Axboe
2020-02-07 15:50 ` [PATCH 4/4] io_uring: allow AT_FDCWD for non-file openat/openat2/statx Jens Axboe
2020-02-07 21:56 ` [PATCHSET 0/4] Allow relative lookups Stefan Metzmacher
2020-02-07 22:47   ` Jens Axboe
2020-02-07 22:56     ` Stefan Metzmacher [this message]
2020-02-07 23:07       ` Stefan Metzmacher
2020-02-08 20:05       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IO-Uring Archive on

Archives are clonable:
	git clone --mirror io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ \
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone