IO-Uring Archive on lore.kernel.org
 help / color / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: axboe@kernel.dk
Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [bug report] io_uring: ensure async punted read/write requests copy iovec
Date: Thu, 5 Dec 2019 14:08:32 +0300
Message-ID: <20191205110832.GN1787@kadam> (raw)
In-Reply-To: <20191205110035.pghb4acsbfr43ycw@kili.mountain>

I see this was fixed in today's linux-next.  That was quick.  :)

regards,
dan caprenter


On Thu, Dec 05, 2019 at 02:00:35PM +0300, Dan Carpenter wrote:
> Hello Jens Axboe,
> 
> The patch f67676d160c6: "io_uring: ensure async punted read/write
> requests copy iovec" from Dec 2, 2019, leads to the following static
> checker warning:
> 
> 	fs/io_uring.c:2919 io_req_defer()
> 	warn: inconsistent returns 'irq'.
> 
> fs/io_uring.c
>   2891  static int io_req_defer(struct io_kiocb *req)
>   2892  {
>   2893          struct io_ring_ctx *ctx = req->ctx;
>   2894          struct io_async_ctx *io;
>   2895          int ret;
>   2896  
>   2897          /* Still need defer if there is pending req in defer list. */
>   2898          if (!req_need_defer(req) && list_empty(&ctx->defer_list))
>   2899                  return 0;
>   2900  
>   2901          io = kmalloc(sizeof(*io), GFP_KERNEL);
>   2902          if (!io)
>   2903                  return -EAGAIN;
>   2904  
>   2905          spin_lock_irq(&ctx->completion_lock);
>   2906          if (!req_need_defer(req) && list_empty(&ctx->defer_list)) {
>   2907                  spin_unlock_irq(&ctx->completion_lock);
>   2908                  kfree(io);
>   2909                  return 0;
>   2910          }
>   2911  
>   2912          ret = io_req_defer_prep(req, io);
>   2913          if (ret < 0)
>   2914                  return ret;
> 
> We need to spin_unlock_irq(&ctx->completion_lock); before returning.
> The question of if we need to kfree(io) is more complicated to me
> because I'm not sure how kiocb->ki_complete gets called...
> 
>   2915  
>   2916          trace_io_uring_defer(ctx, req, req->user_data);
>   2917          list_add_tail(&req->list, &ctx->defer_list);
>   2918          spin_unlock_irq(&ctx->completion_lock);
>   2919          return -EIOCBQUEUED;
>   2920  }
> 
> regards,
> dan carpenter

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05 11:00 Dan Carpenter
2019-12-05 11:08 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191205110832.GN1787@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IO-Uring Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/io-uring/0 io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ https://lore.kernel.org/io-uring \
		io-uring@vger.kernel.org
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.io-uring


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git