io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Kadashev <dkadashev@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <christian.brauner@ubuntu.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
	linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
	Dmitry Kadashev <dkadashev@gmail.com>
Subject: [PATCH v9 00/11] io_uring: add mkdir and [sym]linkat support
Date: Thu,  8 Jul 2021 13:34:36 +0700	[thread overview]
Message-ID: <20210708063447.3556403-1-dkadashev@gmail.com> (raw)

This started out as an attempt to add mkdirat support to io_uring which
is heavily based on renameat() / unlinkat() support.

During the review process more operations were added (linkat, symlinkat,
mknodat) mainly to keep things uniform internally (in namei.c), and
with things changed in namei.c adding support for these operations to
io_uring is trivial, so that was done too (except for mknodat). See
https://lore.kernel.org/io-uring/20210514145259.wtl4xcsp52woi6ab@wittgenstein/

The first patch makes putname() ignore IS_ERR_OR_NULL names and converts
a couple of places where the check was already implemented in the
callers. No functional changes.

The second one splits filename_lookup() that used to consume the passed
struct filename * on error but not on the success (returning it) into
two: filename_lookup(), that always consumes the name and
__filename_lookup() that never does. This is a preparation change to
enable the subsequent changes to filename_create and filename_lookup. No
functional changes.

The third patch is preparation with no functional changes, makes
do_mkdirat accept struct filename pointer rather than the user string.

4-7 just convert other similar do_* functions in namei.c to accept
struct filename, for uniformity with do_mkdirat, do_renameat and
do_unlinkat. No functional changes there.

8 changes do_* helpers in namei.c to return ints rather than some of
them returning ints and some longs.

9-11 leverages the previous changes to add mkdirat, symlinkat and linkat
support to io_uring correspondingly

Based on for-5.14/io_uring.

v9:
- reorder commits to keep io_uring ones nicely grouped at the end
- change 'fs:' to 'namei:' in related commit subjects, since this is
  what seems to be usually used in such cases

v8:
- update filename_parentat() calling conventions to be uniform with the
  ones followed by (changed in subsequent patches) filename_create()
  and filename_lookup()

v7:
- rebase
- make putname() ignore IS_ERR_OR_NULL names, remove conditional calls
  to it from the callers

v6:

- rebase
- add safety checks for IOPOLL mode
- add safety checks for unused sqe parts
- drop mknodat support from io_uring as requested by Jens
- add Christian's Acked-by

v5:
- rebase
- add symlinkat, linkat and mknodat support to io_uring

v4:
- update do_mknodat, do_symlinkat and do_linkat to accept struct
  filename for uniformity with do_mkdirat, do_renameat and do_unlinkat;

v3:
- rebase;

v2:
- do not mess with struct filename's refcount in do_mkdirat, instead add
  and use __filename_create() that does not drop the name on success;

Dmitry Kadashev (11):
  namei: ignore ERR/NULL names in putname()
  namei: change filename_parentat() calling conventions
  namei: make do_mkdirat() take struct filename
  namei: make do_mknodat() take struct filename
  namei: make do_symlinkat() take struct filename
  namei: add getname_uflags()
  namei: make do_linkat() take struct filename
  namei: update do_*() helpers to return ints
  io_uring: add support for IORING_OP_MKDIRAT
  io_uring: add support for IORING_OP_SYMLINKAT
  io_uring: add support for IORING_OP_LINKAT

 fs/exec.c                     |   8 +-
 fs/internal.h                 |   8 +-
 fs/io_uring.c                 | 196 ++++++++++++++++++++++++++++
 fs/namei.c                    | 239 +++++++++++++++++++---------------
 include/linux/fs.h            |   1 +
 include/uapi/linux/io_uring.h |   4 +
 6 files changed, 346 insertions(+), 110 deletions(-)

-- 
2.30.2


             reply	other threads:[~2021-07-08  6:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08  6:34 Dmitry Kadashev [this message]
2021-07-08  6:34 ` [PATCH v9 01/11] namei: ignore ERR/NULL names in putname() Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 02/11] namei: change filename_parentat() calling conventions Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 03/11] namei: make do_mkdirat() take struct filename Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 04/11] namei: make do_mknodat() " Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 05/11] namei: make do_symlinkat() " Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 06/11] namei: add getname_uflags() Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 07/11] namei: make do_linkat() take struct filename Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 08/11] namei: update do_*() helpers to return ints Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 09/11] io_uring: add support for IORING_OP_MKDIRAT Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 10/11] io_uring: add support for IORING_OP_SYMLINKAT Dmitry Kadashev
2021-07-08  6:34 ` [PATCH v9 11/11] io_uring: add support for IORING_OP_LINKAT Dmitry Kadashev
2021-07-08 18:34 ` [PATCH v9 00/11] io_uring: add mkdir and [sym]linkat support Linus Torvalds
2021-07-08 19:25   ` Jens Axboe
2021-08-13  9:32     ` Dmitry Kadashev
2021-08-13 14:12       ` Jens Axboe
2021-08-16 10:24         ` Dmitry Kadashev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210708063447.3556403-1-dkadashev@gmail.com \
    --to=dkadashev@gmail.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=christian.brauner@ubuntu.com \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).