io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: David Sterba <dsterba@suse.cz>
Cc: Stefan Roesch <shr@fb.com>,
	kernel-team@fb.com, io-uring@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk,
	josef@toxicpanda.com, fdmanana@gmail.com
Subject: Re: [PATCH v3 00/12] io-uring/btrfs: support async buffered writes
Date: Wed, 21 Sep 2022 12:19:58 +0200	[thread overview]
Message-ID: <20220921101958.GE32411@twin.jikos.cz> (raw)
In-Reply-To: <20220920122540.GY32411@twin.jikos.cz>

On Tue, Sep 20, 2022 at 02:25:40PM +0200, David Sterba wrote:
> On Mon, Sep 12, 2022 at 12:27:40PM -0700, Stefan Roesch wrote:
> > This patch series adds support for async buffered writes when using both
> > btrfs and io-uring. Currently io-uring only supports buffered writes (for btrfs)
> > in the slow path, by processing them in the io workers. With this patch series
> > it is now possible to support buffered writes in the fast path. To be able to use
> > the fast path, the required pages must be in the page cache, the required locks
> > in btrfs can be granted immediately and no additional blocks need to be read
> > form disk.
> > 
> > This patch series makes use of the changes that have been introduced by a
> > previous patch series: "io-uring/xfs: support async buffered writes"
> > 
> > Performance results:
> > 
> > The new patch improves throughput by over two times (compared to the exiting
> > behavior, where buffered writes are processed by an io-worker process) and also
> > the latency is considerably reduced. Detailled results are part of the changelog
> > of the first commit.
> 
> Thanks. It's late for including this patches to 6.1 queue but it's now
> in for-next and will be added to misc-next after rc1, targeting merge to
> 6.2. I did some minor fixups, so please don't resend full series unless
> there's a significant change. Incremental changes are fine if needed.

I'm revisiting the merge target, the potential risk seems to be low
here, straightforward changes for a separate feature, so it's now in the
6.1 queue. We still don't have ack for the function export so that would
be good to have.

  reply	other threads:[~2022-09-21 10:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12 19:27 [PATCH v3 00/12] io-uring/btrfs: support async buffered writes Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 01/12] mm: export balance_dirty_pages_ratelimited_flags() Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 02/12] btrfs: implement a nowait option for tree searches Stefan Roesch
2022-09-26  9:14   ` Filipe Manana
2022-09-26 10:55     ` David Sterba
2022-09-12 19:27 ` [PATCH v3 03/12] btrfs: make can_nocow_extent nowait compatible Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 04/12] btrfs: add the ability to use NO_FLUSH for data reservations Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 05/12] btrfs: add btrfs_try_lock_ordered_range Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 06/12] btrfs: make btrfs_check_nocow_lock nowait compatible Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 07/12] btrfs: make prepare_pages " Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 08/12] btrfs: make lock_and_cleanup_extent_if_need " Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 09/12] btrfs: plumb NOWAIT through the write path Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 10/12] btrfs: make balance_dirty_pages nowait compatible Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 11/12] btrfs: assert nowait mode is not used for some btree search functions Stefan Roesch
2022-09-12 19:27 ` [PATCH v3 12/12] btrfs: enable nowait async buffered writes Stefan Roesch
2022-09-13  9:47 ` [PATCH v3 00/12] io-uring/btrfs: support " Filipe Manana
2022-09-20 12:25 ` David Sterba
2022-09-21 10:19   ` David Sterba [this message]
2022-09-21 14:33     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921101958.GE32411@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=axboe@kernel.dk \
    --cc=fdmanana@gmail.com \
    --cc=io-uring@vger.kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shr@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).