IO-Uring Archive on lore.kernel.org
 help / color / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Stefan Metzmacher <metze@samba.org>, io-uring@vger.kernel.org
Subject: Re: [PATCH v1] io_uring_cqe_get_data() only requires a const struct io_uring_cqe *cqe
Date: Thu, 6 Feb 2020 12:13:58 -0700
Message-ID: <2bf57f94-aaf4-8da6-b05f-9e9356c57151@kernel.dk> (raw)
In-Reply-To: <1c61d1da-9c1e-2d57-81da-f251d8e1992a@samba.org>

On 2/6/20 10:05 AM, Stefan Metzmacher wrote:
>>> While researching that I noticed that IOSQE_FIXED_FILE
>>> seems to be ignored for some new commands, I think that
>>> all commands with on input fd, should be able to use that flag.
>>> Can this be fixed before 5.6 final?
>>
>> Do you have specifics? Generally the file grabbing happens as part of
>> request prep, and the individual opcodes should not need to bother with
>> it.
> 
> io_statx_prep():
> io_openat_prep():
> io_openat2_prep():
> 
>   req->open.dfd = READ_ONCE(sqe->fd);
> 
> 
> io_statx():
>   ret = filename_lookup(ctx->dfd, ctx->filename, lookup_flags...
> 
> io_openat2():
> 
>   file = do_filp_open(req->open.dfd, req->open.filename, &op);
> 
> io_close_prep(): has this to make it clear that IOSQE_FIXED_FILE is not
> supported, I guess because FILE_UPDATE with -1 needs to be used instead?
> 
>         if (sqe->flags & IOSQE_FIXED_FILE)
>                 return -EINVAL;
> 
>         req->close.fd = READ_ONCE(sqe->fd);
> 
> 
> I guess at least we need if (sqe->flags & IOSQE_FIXED_FILE) in all
> cases, if we can't just fix it.

Ah yes good point, on both honoring it and failing it for close() when
we do honor it. I'll fix that up.

-- 
Jens Axboe


  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 16:02 Stefan Metzmacher
2020-02-06 16:04 ` Jens Axboe
2020-02-06 16:37   ` Stefan Metzmacher
2020-02-06 16:42     ` Jens Axboe
2020-02-06 17:05       ` Stefan Metzmacher
2020-02-06 19:13         ` Jens Axboe [this message]
2020-02-07 23:45   ` Stefan Metzmacher
2020-02-08 19:53     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bf57f94-aaf4-8da6-b05f-9e9356c57151@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=metze@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IO-Uring Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/io-uring/0 io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ https://lore.kernel.org/io-uring \
		io-uring@vger.kernel.org
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.io-uring


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git