From: Pavel Begunkov <asml.silence@gmail.com>
To: Bob Liu <bob.liu@oracle.com>, Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org
Subject: Re: io_uring: io_fail_links() should only consider first linked timeout
Date: Wed, 20 Nov 2019 17:28:10 +0300 [thread overview]
Message-ID: <2df3dc51-5707-efad-63a4-87c7e0931b36@gmail.com> (raw)
In-Reply-To: <11ab7750-6009-1228-af70-bc6b4604b245@oracle.com>
On 11/20/2019 5:03 PM, Bob Liu wrote:
> I see, thanks.
> As for me, it may better return -EINVAL in advance so as to skip a lot unnecessary code for those reqs.
>
Hah, I removed similar check just yesterday (see [PATCH 3/4] "io_uring:
remove redundant check"). We don't care about performance of invalid
requests, and this one in hot-path. The fewer edge cases, the better.
Also, for the example below, I'd want to fail INVALID_REQ and cancel
valid ones, but not exit after processing invalid, or even worse
processing the rest without it.
INVALID_REQ -> VALID_REQ -> VALID_REQ.
> @@ -3176,6 +3176,7 @@ static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr,
>
> if (!io_get_sqring(ctx, &req->submit)) {
> }
> ...
> + if (unlikely(req_is_invalid(req)))
> + return -EINVAL;
>
--
Pavel Begunkov
next prev parent reply other threads:[~2019-11-20 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 22:33 io_uring: io_fail_links() should only consider first linked timeout Jens Axboe
2019-11-20 8:44 ` Pavel Begunkov
2019-11-20 10:22 ` Bob Liu
2019-11-20 11:07 ` Pavel Begunkov
2019-11-20 14:03 ` Bob Liu
2019-11-20 14:23 ` Jens Axboe
2019-11-20 14:28 ` Pavel Begunkov [this message]
2019-11-20 14:22 ` Jens Axboe
2019-11-20 15:02 ` Pavel Begunkov
2019-11-20 15:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df3dc51-5707-efad-63a4-87c7e0931b36@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bob.liu@oracle.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).