From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring: rename __io_submit_sqe()
Date: Thu, 21 Nov 2019 13:34:56 -0700 [thread overview]
Message-ID: <3155b873-c790-db01-22e0-068f06bcf82e@kernel.dk> (raw)
In-Reply-To: <8b5be6c6-5160-24e5-ee41-a50690be93b6@gmail.com>
On 11/21/19 1:30 PM, Pavel Begunkov wrote:
> On 21/11/2019 23:08, Jens Axboe wrote:
>> On 11/21/19 11:24 AM, Pavel Begunkov wrote:
>>> __io_submit_sqe() is issuing requests, so call it as
>>> such. Moreover, it ends by calling io_iopoll_req_issued().
>>>
>>> Rename it and make terminology clearer.
>>
>> I'm fine with this (and the other patch), but will push them
>> to the back of the pile for once the merge window stuff is over.
>>
> Not a problem. Then, I'll send remaining patches later.
You can just keep piling them on, that's fine. Just keep in mind
that the merge window is opening this weekend, so it has to make
sense in that context.
--
Jens Axboe
next prev parent reply other threads:[~2019-11-21 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 18:24 [PATCH] io_uring: rename __io_submit_sqe() Pavel Begunkov
2019-11-21 20:08 ` Jens Axboe
2019-11-21 20:30 ` Pavel Begunkov
2019-11-21 20:34 ` Jens Axboe [this message]
2019-11-22 6:11 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3155b873-c790-db01-22e0-068f06bcf82e@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).