IO-Uring Archive on lore.kernel.org
 help / color / Atom feed
* [liburing patch] barrier.h: add generic smp_mb implementation
@ 2019-11-05 15:33 Jeff Moyer
  2019-11-05 15:35 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Moyer @ 2019-11-05 15:33 UTC (permalink / raw)
  To: axboe; +Cc: io-uring

This missing define causes build failures on s390:

  src/include/liburing.h:298: undefined reference to `io_uring_smp_mb'

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>

diff --git a/src/include/liburing/barrier.h b/src/include/liburing/barrier.h
index fc40a8a..aca308a 100644
--- a/src/include/liburing/barrier.h
+++ b/src/include/liburing/barrier.h
@@ -76,6 +76,7 @@ do {						\
  * Add arch appropriate definitions. Be safe and use full barriers for
  * archs we don't have support for.
  */
+#define io_uring_smp_mb()	__sync_synchronize()
 #define io_uring_smp_rmb()	__sync_synchronize()
 #define io_uring_smp_wmb()	__sync_synchronize()
 #endif /* defined(__x86_64__) || defined(__i386__) */


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [liburing patch] barrier.h: add generic smp_mb implementation
  2019-11-05 15:33 [liburing patch] barrier.h: add generic smp_mb implementation Jeff Moyer
@ 2019-11-05 15:35 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-11-05 15:35 UTC (permalink / raw)
  To: Jeff Moyer; +Cc: io-uring

On 11/5/19 8:33 AM, Jeff Moyer wrote:
> This missing define causes build failures on s390:
> 
>    src/include/liburing.h:298: undefined reference to `io_uring_smp_mb'

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 15:33 [liburing patch] barrier.h: add generic smp_mb implementation Jeff Moyer
2019-11-05 15:35 ` Jens Axboe

IO-Uring Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/io-uring/0 io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ https://lore.kernel.org/io-uring \
		io-uring@vger.kernel.org
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.io-uring


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git