IO-Uring Archive on lore.kernel.org
 help / color / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH v1 1/3] configure/Makefile: introduce libdevdir defaults to $(libdir)
Date: Fri, 7 Feb 2020 15:19:52 +0100
Message-ID: <35cb2c1e-5985-13a8-1719-1bfa9aeb65a4@samba.org> (raw)
In-Reply-To: <20200206170758.29285-1-metze@samba.org>

[-- Attachment #1.1: Type: text/plain, Size: 347 bytes --]

Hi Jens,

>  ifeq ($(ENABLE_SHARED),1)
>  	install -D -m 755 $(libname) $(libdir)/$(libname)
>  	ln -sf $(libname) $(libdir)/$(soname)
> -	ln -sf $(libname) $(libdir)/liburing.so
> +	ln -sf $(libname) $(libdevdir)/liburing.so

The source of this symlink is wrong if libdir != libdevdir.

I'm working on a fix, sorry...

metze





[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 17:07 Stefan Metzmacher
2020-02-06 17:07 ` [PATCH v1 2/3] debian: package liburing-0.4 and use a layout as the libaio package Stefan Metzmacher
2020-02-06 17:07 ` [PATCH v1 3/3] liburing.spec move to liburing-0.4 Stefan Metzmacher
2020-02-07 14:19 ` Stefan Metzmacher [this message]
2020-02-07 14:42   ` [PATCH v2] Fix liburing.so symlink source if libdir != libdevdir Stefan Metzmacher
2020-02-07 16:24     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35cb2c1e-5985-13a8-1719-1bfa9aeb65a4@samba.org \
    --to=metze@samba.org \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IO-Uring Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/io-uring/0 io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ https://lore.kernel.org/io-uring \
		io-uring@vger.kernel.org
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.io-uring


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git