From: Stefan Metzmacher <metze@samba.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH v1 1/3] configure/Makefile: introduce libdevdir defaults to $(libdir)
Date: Fri, 7 Feb 2020 15:19:52 +0100 [thread overview]
Message-ID: <35cb2c1e-5985-13a8-1719-1bfa9aeb65a4@samba.org> (raw)
In-Reply-To: <20200206170758.29285-1-metze@samba.org>
[-- Attachment #1.1: Type: text/plain, Size: 347 bytes --]
Hi Jens,
> ifeq ($(ENABLE_SHARED),1)
> install -D -m 755 $(libname) $(libdir)/$(libname)
> ln -sf $(libname) $(libdir)/$(soname)
> - ln -sf $(libname) $(libdir)/liburing.so
> + ln -sf $(libname) $(libdevdir)/liburing.so
The source of this symlink is wrong if libdir != libdevdir.
I'm working on a fix, sorry...
metze
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-02-07 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 17:07 [PATCH v1 1/3] configure/Makefile: introduce libdevdir defaults to $(libdir) Stefan Metzmacher
2020-02-06 17:07 ` [PATCH v1 2/3] debian: package liburing-0.4 and use a layout as the libaio package Stefan Metzmacher
2020-02-06 17:07 ` [PATCH v1 3/3] liburing.spec move to liburing-0.4 Stefan Metzmacher
2020-02-07 14:19 ` Stefan Metzmacher [this message]
2020-02-07 14:42 ` [PATCH v2] Fix liburing.so symlink source if libdir != libdevdir Stefan Metzmacher
2020-02-07 16:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35cb2c1e-5985-13a8-1719-1bfa9aeb65a4@samba.org \
--to=metze@samba.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).