io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hao Xu <haoxu@linux.alibaba.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
	Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH v2] io_uring: fix bug of wrong BUILD_BUG_ON check of __REQ_F_LAST_BIT
Date: Fri, 10 Sep 2021 19:50:45 +0800	[thread overview]
Message-ID: <39514727-827c-6920-2ffc-c0aa06bb2c9d@linux.alibaba.com> (raw)
In-Reply-To: <20210907032243.114190-1-haoxu@linux.alibaba.com>

ping
在 2021/9/7 上午11:22, Hao Xu 写道:
> Build check of __REQ_F_LAST_BIT should be large than not equal or large
> than.
> 
> Signed-off-by: Hao Xu <haoxu@linux.alibaba.com>
> ---
>   fs/io_uring.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 2bde732a1183..d159d9204e07 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -10643,7 +10643,7 @@ static int __init io_uring_init(void)
>   	BUILD_BUG_ON(SQE_VALID_FLAGS >= (1 << 8));
>   
>   	BUILD_BUG_ON(ARRAY_SIZE(io_op_defs) != IORING_OP_LAST);
> -	BUILD_BUG_ON(__REQ_F_LAST_BIT >= 8 * sizeof(int));
> +	BUILD_BUG_ON(__REQ_F_LAST_BIT > 8 * sizeof(int));
>   
>   	req_cachep = KMEM_CACHE(io_kiocb, SLAB_HWCACHE_ALIGN | SLAB_PANIC |
>   				SLAB_ACCOUNT);
> 


  reply	other threads:[~2021-09-10 11:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07  3:22 Hao Xu
2021-09-10 11:50 ` Hao Xu [this message]
2021-09-10 12:26 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39514727-827c-6920-2ffc-c0aa06bb2c9d@linux.alibaba.com \
    --to=haoxu@linux.alibaba.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=joseph.qi@linux.alibaba.com \
    --subject='Re: [PATCH v2] io_uring: fix bug of wrong BUILD_BUG_ON check of __REQ_F_LAST_BIT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).