From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH v2] io_uring: add flag to not fail link after timeout
Date: Sat, 2 Oct 2021 08:58:17 -0600 [thread overview]
Message-ID: <448c3b57-3c3a-37c6-5f58-b0a7ba51b497@kernel.dk> (raw)
In-Reply-To: <52a381383c5ef08e20fa141ad21ee3e72aaa2857.1633120064.git.asml.silence@gmail.com>
On 10/2/21 2:44 AM, Pavel Begunkov wrote:
> For some reason non-off IORING_OP_TIMEOUT always fails links, it's
> pretty inconvenient and unnecessary limits chaining after it to hard
> linking, which is far from ideal, e.g. doesn't pair well with timeout
> cancellation. Prevent it and treat -ETIME as success.
That seems like a sane addition, but I'm not a huge fan of the
#define IORING_TIMEOUT_DONT_FAIL (1U << 5)
name, as it isn't very descriptive. Don't fail what? Maybe
#define IORING_TIMEOUT_ETIME_SUCCESS
instead? At least that tells the story of -ETIME being considered
success, hence not breaking a link.
--
Jens Axboe
next prev parent reply other threads:[~2021-10-02 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 8:44 [PATCH v2] io_uring: add flag to not fail link after timeout Pavel Begunkov
2021-10-02 14:58 ` Jens Axboe [this message]
2021-10-02 16:18 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448c3b57-3c3a-37c6-5f58-b0a7ba51b497@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).