From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring <io-uring@vger.kernel.org>
Subject: io_close()
Date: Fri, 7 Feb 2020 23:52:34 +0300 [thread overview]
Message-ID: <45f22c50-1ffe-4b73-f213-08dd49233597@gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 297 bytes --]
Hi,
I noticed, that io_close() is broken for some use cases, and was thinking about
the best way to fix it. Is fput(req->close.put_file) really need to be done in
wq? It seems, fput_many() implementation just calls schedule_delayed_work(), so
it's already delayed.
--
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2020-02-07 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 20:52 Pavel Begunkov [this message]
2020-02-07 21:14 ` io_close() Jens Axboe
2020-02-07 21:19 ` io_close() Pavel Begunkov
2020-02-07 21:35 ` io_close() Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45f22c50-1ffe-4b73-f213-08dd49233597@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).