From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH liburing 1/1] tests: fix poll-mshot-update
Date: Tue, 24 Aug 2021 12:04:46 -0600 [thread overview]
Message-ID: <5565df54-2711-f732-2818-c8158f235e33@kernel.dk> (raw)
In-Reply-To: <7e588f712ec61e0ddc619ce016d1c3b9445716e1.1629826707.git.asml.silence@gmail.com>
On 8/24/21 11:38 AM, Pavel Begunkov wrote:
> poll-mshot-update constantly hangs. Apparently, the reason is
> reap_polls() clearing ->triggered flags racing with trigger_polls()
> setting them. So, reinit the flags only after joining the thread.
>
> Also, replace magic constants with proper identificators, e.g.
> 1 -> IORING_POLL_ADD_MULTI.
Good catch!
--
Jens Axboe
prev parent reply other threads:[~2021-08-24 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 17:38 [PATCH liburing 1/1] tests: fix poll-mshot-update Pavel Begunkov
2021-08-24 18:04 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5565df54-2711-f732-2818-c8158f235e33@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).