From: Hao Xu <haoxu@linux.alibaba.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH] io-wq: fix memory leak in create_io_worker()
Date: Thu, 9 Sep 2021 21:00:47 +0800 [thread overview]
Message-ID: <574bb7cd-c0e4-14d3-8afa-2f892a7b78bd@linux.alibaba.com> (raw)
In-Reply-To: <d3351ea9-5389-1cd9-ba11-5df4c030f87b@kernel.dk>
在 2021/9/9 下午8:57, Jens Axboe 写道:
> On 9/8/21 10:05 PM, Hao Xu wrote:
>> We should free memory the variable worker point to in fail path.
>
> I think this one is missing a few paths where it can also happen, once
> punted.
True. I browse the code again and I think Qiang.zhang's patch should be
fine.
>
next prev parent reply other threads:[~2021-09-09 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 4:05 [PATCH] io-wq: fix memory leak in create_io_worker() Hao Xu
2021-09-09 12:57 ` Jens Axboe
2021-09-09 13:00 ` Hao Xu [this message]
2021-09-09 15:41 ` Jens Axboe
2021-09-09 11:58 qiang.zhang
2021-09-09 12:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574bb7cd-c0e4-14d3-8afa-2f892a7b78bd@linux.alibaba.com \
--to=haoxu@linux.alibaba.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=joseph.qi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).