From: Jens Axboe <axboe@kernel.dk>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: linux-kernel@vger.kernel.org, io-uring@vger.kernel.org
Subject: Re: [PATCH liburing v2 0/1] test: add epoll test case
Date: Thu, 6 Feb 2020 12:46:51 -0700 [thread overview]
Message-ID: <57766a26-866b-3288-dc69-5104de3ac6b6@kernel.dk> (raw)
In-Reply-To: <CAGxU2F6qvW28=ULNUi-UHethus2bO6VXYX127HOcH_KPToZC-w@mail.gmail.com>
On 2/6/20 10:33 AM, Stefano Garzarella wrote:
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 77f22c3da30f..2769451af89a 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -6301,7 +6301,7 @@ static __poll_t io_uring_poll(struct file *file, poll_table *wait)
> if (READ_ONCE(ctx->rings->sq.tail) - ctx->cached_sq_head !=
> ctx->rings->sq_ring_entries)
> mask |= EPOLLOUT | EPOLLWRNORM;
> - if (READ_ONCE(ctx->rings->cq.head) != ctx->cached_cq_tail)
> + if (!io_cqring_events(ctx, false))
> mask |= EPOLLIN | EPOLLRDNORM;
>
> return mask;
Are you going to send this as a proper patch? If so, I think you'll want
to remove the '!' negation for that check.
--
Jens Axboe
next prev parent reply other threads:[~2020-02-06 19:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 14:29 [PATCH liburing v2 0/1] test: add epoll test case Stefano Garzarella
2020-01-31 14:29 ` [PATCH liburing v2 1/1] " Stefano Garzarella
2020-01-31 15:41 ` Jens Axboe
2020-02-03 9:04 ` Stefano Garzarella
2020-02-03 15:43 ` Jens Axboe
2020-01-31 15:39 ` [PATCH liburing v2 0/1] " Jens Axboe
2020-02-03 9:03 ` Stefano Garzarella
2020-02-06 17:33 ` Stefano Garzarella
2020-02-06 19:15 ` Jens Axboe
2020-02-06 19:51 ` Jens Axboe
2020-02-06 20:12 ` Stefano Garzarella
2020-02-06 19:46 ` Jens Axboe [this message]
2020-02-07 16:51 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57766a26-866b-3288-dc69-5104de3ac6b6@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).