From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C88D9C433DB for ; Tue, 2 Feb 2021 21:02:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C1AC64DD5 for ; Tue, 2 Feb 2021 21:02:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233670AbhBBVBc (ORCPT ); Tue, 2 Feb 2021 16:01:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231902AbhBBVBS (ORCPT ); Tue, 2 Feb 2021 16:01:18 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29D44C061573 for ; Tue, 2 Feb 2021 13:00:38 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id 190so3705580wmz.0 for ; Tue, 02 Feb 2021 13:00:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/kqeqAMWpmnEtD1e7+Op/iuMsfrpmPEbzwW5kAvN6mA=; b=GKh+4yF9pPk7H6H3XVXdQir2Re+kDlZJtmlYnbp/cr3razDoVltM5nfceQTcCpCzrj gSbS3VEpoq0whYic1tdNKu39dQqkmO0LB3lo+lK2lBsPpPU+r9xq+zcf5FxFybEmhj7k ThoNJQkcEoMqN3RwcbYCUrCnK1lSgd1rrdLKRi4wB1HuTzwuFDkyv/f/C/5ONH3WY89O DcLoQ3hwPIvTL7bm7+rU++a22swkk8Cxl15CICHygiUszp4N4ZXKDDtsWKj5ibd2Xiol IZKUhznl6CRyBNE0p5fegIg7MCY6jxTn8Xe+u4/uOSiy9mt2n9solH0fwAH7o1r5G5yD nbqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/kqeqAMWpmnEtD1e7+Op/iuMsfrpmPEbzwW5kAvN6mA=; b=kaJHdP4AF1HBb49Jg7bkkQatY1lc4wh6y3kNdehG0bk/zv3zYfmhmd2I6bsjaB3gR/ nNE/Y0r5w96uwGx3yV9TX8Lm93VqxROP3h/ZGdlO89jKLJJCIMEFCMKg+wgA+xOe3EeY mvpb6zPm1ptQ7LaxfsKgxlI3L6PkS8Kjc/7kFyBZfi0IyxPIMH5Pf960+xmNZsxxo7aO PohEu/pCVPs+5yvsA/dRNMRSOEy1LumeoR6veCmLbv0I9viH5YtPNkOTpf8r1zKVr16x A1vLhMtkeWsHUgAnaNcgEdHxtn9wACm4l2vWuaJD3HCQj/La77/0SuWDU3wHau0Xvbvx xznA== X-Gm-Message-State: AOAM530NaLKXJdGQRYcaZ0+RMVxNoeF9V8KBYyMlZgrC8FLEhg5mvN47 qq/zrThadDmeIZ2Mp4QM2QKeKCbHCrATQA== X-Google-Smtp-Source: ABdhPJzkG5WQ24wsu9ro5t0B8YUNCAk/Jkf9JnR9K/C3KoIxCm8cSD8xC+ajMB/s3GYaEI23kmICdQ== X-Received: by 2002:a05:600c:204e:: with SMTP id p14mr4315240wmg.157.1612299636675; Tue, 02 Feb 2021 13:00:36 -0800 (PST) Received: from [192.168.8.171] ([185.69.145.241]) by smtp.gmail.com with ESMTPSA id d13sm34005167wrx.93.2021.02.02.13.00.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 13:00:35 -0800 (PST) To: Jens Axboe , Victor Stewart Cc: io-uring References: <49743b61-3777-f152-e1d5-128a53803bcd@gmail.com> <4b44f4e1-c039-a6b6-711f-22952ce1abfb@kernel.dk> <06ceae30-7221-80e9-13e3-148cdf5e3c9f@kernel.dk> <8d75bf78-7361-0649-e5a3-1288fea1197f@gmail.com> <725fa06a-da7e-9918-49b4-7489672ff0b4@kernel.dk> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Subject: Re: bug with fastpoll accept and sqpoll + IOSQE_FIXED_FILE Message-ID: <5c3d084f-88e4-3e86-3560-95d90bb9ffcd@gmail.com> Date: Tue, 2 Feb 2021 20:56:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <725fa06a-da7e-9918-49b4-7489672ff0b4@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 02/02/2021 20:48, Jens Axboe wrote: > On 2/2/21 1:34 PM, Pavel Begunkov wrote: >> On 02/02/2021 17:41, Pavel Begunkov wrote: >>> On 02/02/2021 17:24, Jens Axboe wrote: >>>> On 2/2/21 10:10 AM, Victor Stewart wrote: >>>>>> Can you send the updated test app? >>>>> >>>>> https://gist.github.com/victorstewart/98814b65ed702c33480487c05b40eb56 >>>>> >>>>> same link i just updated the same gist >>>> >>>> And how are you running it? >>> >>> with SQPOLL with FIXED FLAG -> FAILURE: failed with error = ??? >>> -> io_uring_wait_cqe_timeout() strangely returns -1, (-EPERM??) >> >> Ok, _io_uring_get_cqe() is just screwed twice >> >> TL;DR >> we enter into it with submit=0, do an iteration, which decrements it, >> then a second iteration passes submit=-1, which is returned back by >> the kernel as a result and propagated back from liburing... > > Yep, that's what I came up with too. We really just need a clear way > of knowing when to break out, and when to keep going. Eg if we've > done a loop and don't end up calling the system call, then there's > no point in continuing. We can bodge something up (and forget about it), and do much cleaner for IORING_FEAT_EXT_ARG, because we don't have LIBURING_UDATA_TIMEOUT reqs for it and so can remove peek and so on. -- Pavel Begunkov