From: Jens Axboe <axboe@kernel.dk>
To: Jackie Liu <liuyun01@kylinos.cn>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH v2] io_uring: reduced function parameter ctx if possible
Date: Fri, 8 Nov 2019 07:11:55 -0700 [thread overview]
Message-ID: <5c685b0e-077a-9472-0f2b-982ecfffe9d9@kernel.dk> (raw)
In-Reply-To: <1573198177-177651-1-git-send-email-liuyun01@kylinos.cn>
On 11/8/19 12:29 AM, Jackie Liu wrote:
> Many times, the core of the function is req, and req has already set
> req->ctx at initialization time, so there is no need to pass in from
> outside.
>
> Cleanup, no function change.
I was curious if this patch netted us any improvements as well, but it
actually blows up the text segment a lot on my laptop. Before the
patch:
text data bss dec hex filename
87504 17588 256 105348 19b84 fs/io_uring.o
and after:
text data bss dec hex filename
99098 17876 256 117230 1c9ee fs/io_uring.o
which seems really odd. I double checked just to be sure!
axboe@x1:~ $ gcc --version
gcc (Ubuntu 9.2.1-17ubuntu1~18.04.1) 9.2.1 20191102
--
Jens Axboe
next prev parent reply other threads:[~2019-11-08 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 7:29 [PATCH v2] io_uring: reduced function parameter ctx if possible Jackie Liu
2019-11-08 9:00 ` Jackie Liu
2019-11-08 9:10 ` Bob Liu
[not found] ` <7B6E98CA-22DE-4AFA-94C3-D65395A1629C@kylinos.cn>
2019-11-08 9:24 ` Jackie Liu
2019-11-08 9:35 ` Bob Liu
2019-11-08 14:11 ` Jens Axboe [this message]
2019-11-08 14:16 ` Jens Axboe
[not found] ` <5dc57d18.1c69fb81.78a44.b83dSMTPIN_ADDED_BROKEN@mx.google.com>
2019-11-08 14:39 ` Jens Axboe
[not found] ` <5dc57f27.1c69fb81.27d15.ccf4SMTPIN_ADDED_BROKEN@mx.google.com>
2019-11-08 14:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c685b0e-077a-9472-0f2b-982ecfffe9d9@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).