From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] io-wq: handle hashed writes in chains
Date: Mon, 23 Mar 2020 20:31:36 -0600 [thread overview]
Message-ID: <637ca8a0-d116-dbea-5949-2462502df4bb@kernel.dk> (raw)
In-Reply-To: <c0e464556675bd40ea47d61ce12e2393603ce43c.1584993396.git.asml.silence@gmail.com>
On 3/23/20 1:57 PM, Pavel Begunkov wrote:
> We always punt async buffered writes to an io-wq helper, as the core
> kernel does not have IOCB_NOWAIT support for that. Most buffered async
> writes complete very quickly, as it's just a copy operation. This means
> that doing multiple locking roundtrips on the shared wqe lock for each
> buffered write is wasteful. Additionally, buffered writes are hashed
> work items, which means that any buffered write to a given file is
> serialized.
>
> Keep identicaly hashed work items contiguously in @wqe->work_list, and
> track a tail for each hash bucket. On dequeue of a hashed item, splice
> all of the same hash in one go using the tracked tail. Until the batch
> is done, the caller doesn't have to synchronize with the wqe or worker
> locks again.
Looks good to me, and also passes testing. I've applied this for 5.7.
Next we can start looking into cases where it'd be an improvement
to kick off another worker. Say if we still have work after grabbing
a chain, would probably not be a bad idea.
--
Jens Axboe
next prev parent reply other threads:[~2020-03-24 2:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 19:57 [PATCH v2] io-wq: handle hashed writes in chains Pavel Begunkov
2020-03-24 2:31 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-19 18:56 Jens Axboe
2020-03-22 16:09 ` Pavel Begunkov
2020-03-22 16:24 ` Pavel Begunkov
2020-03-22 17:08 ` Jens Axboe
2020-03-22 18:54 ` Pavel Begunkov
2020-03-22 19:51 ` Jens Axboe
2020-03-22 20:05 ` Jens Axboe
2020-03-22 20:15 ` Jens Axboe
2020-03-22 20:20 ` Pavel Begunkov
2020-03-22 21:16 ` Pavel Begunkov
2020-03-22 21:31 ` Pavel Begunkov
2020-03-22 20:25 ` Pavel Begunkov
2020-03-23 1:37 ` Jens Axboe
2020-03-23 8:38 ` Pavel Begunkov
2020-03-23 14:26 ` Jens Axboe
2020-03-22 17:08 ` Jens Axboe
2020-03-22 17:37 ` Pavel Begunkov
2020-03-22 20:56 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=637ca8a0-d116-dbea-5949-2462502df4bb@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).