From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] io_uring: add cleanup for openat()/statx()
Date: Sat, 8 Feb 2020 00:18:48 +0300 [thread overview]
Message-ID: <66ab5ebd-8a9c-47bc-1bf2-8a328e70c290@gmail.com> (raw)
In-Reply-To: <10b7caed-06dd-f6a0-24f1-648968011e40@kernel.dk>
[-- Attachment #1.1: Type: text/plain, Size: 606 bytes --]
On 08/02/2020 00:13, Jens Axboe wrote:
> On 2/7/20 1:59 PM, Pavel Begunkov wrote:
>> openat() and statx() may have allocated ->open.filename, which should be
>> be put. Add cleanup handlers for them.
>
> Thanks, applied - but I dropped this hunk:
That's the second time it slipped, I need to read patches more attentively.
Thanks
>
>> @@ -2857,7 +2862,6 @@ static void io_close_finish(struct io_wq_work **workptr)
>> }
>>
>> fput(req->close.put_file);
>> -
>> io_put_req_find_next(req, &nxt);
>> if (nxt)
>> io_wq_assign_next(workptr, nxt);
>
--
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-02-07 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 20:59 [PATCH v2] io_uring: add cleanup for openat()/statx() Pavel Begunkov
2020-02-07 21:13 ` Jens Axboe
2020-02-07 21:18 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66ab5ebd-8a9c-47bc-1bf2-8a328e70c290@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).