From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Subject: [PATCH liburing 2/2] tests: rename iopoll test variables
Date: Thu, 19 Aug 2021 14:42:22 +0100 [thread overview]
Message-ID: <66e749793b37a702c1ac37556c1e354e9dff3298.1629380408.git.asml.silence@gmail.com> (raw)
In-Reply-To: <cover.1629380408.git.asml.silence@gmail.com>
Rename v1-v4 variables into something more descriptive, makes debugging
easier.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
test/iopoll.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/test/iopoll.c b/test/iopoll.c
index 1adee7f..b450618 100644
--- a/test/iopoll.c
+++ b/test/iopoll.c
@@ -347,15 +347,15 @@ int main(int argc, char *argv[])
if (no_buf_select)
nr = 8;
for (i = 0; i < nr; i++) {
- int v1, v2, v3, v4;
+ int write = (i & 1) != 0;
+ int sqthread = (i & 2) != 0;
+ int fixed = (i & 4) != 0;
+ int buf_select = (i & 8) != 0;
- v1 = (i & 1) != 0;
- v2 = (i & 2) != 0;
- v3 = (i & 4) != 0;
- v4 = (i & 8) != 0;
- ret = test_io(fname, v1, v2, v3, v4);
+ ret = test_io(fname, write, sqthread, fixed, buf_select);
if (ret) {
- fprintf(stderr, "test_io failed %d/%d/%d/%d\n", v1, v2, v3, v4);
+ fprintf(stderr, "test_io failed %d/%d/%d/%d\n",
+ write, sqthread, fixed, buf_select);
goto err;
}
if (no_iopoll)
--
2.32.0
next prev parent reply other threads:[~2021-08-19 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 13:42 [PATCH liburing 0/2] rw tests improvements Pavel Begunkov
2021-08-19 13:42 ` [PATCH liburing 1/2] tests: create new files for rw testing Pavel Begunkov
2021-08-19 13:42 ` Pavel Begunkov [this message]
2021-08-19 14:48 ` [PATCH liburing 0/2] rw tests improvements Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66e749793b37a702c1ac37556c1e354e9dff3298.1629380408.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).