io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>,
	io-uring@vger.kernel.org
Cc: asml.silence@gmail.com
Subject: Re: [PATCH] io_uring: add missing sigmask restore in io_cqring_wait()
Date: Tue, 14 Sep 2021 08:29:46 -0600	[thread overview]
Message-ID: <6fe24a51-4d66-de57-add6-42cb5e980886@kernel.dk> (raw)
In-Reply-To: <f0c26fd2-667f-8f94-446d-4da064a712d9@linux.alibaba.com>

On 9/14/21 8:28 AM, Xiaoguang Wang wrote:
> hi,
> 
> 
>> On 9/14/21 2:41 AM, Xiaoguang Wang wrote:
>>> Found this by learning codes.
>> Does look like a real bug. But how about we move the get_timespec() section
>> before the sigmask saving?
> 
> Ok,  I thought about this method before :)

When you send a v2 with that, please do also write a proper commit message.
It should explain why the change is needed. Thanks!

-- 
Jens Axboe


      reply	other threads:[~2021-09-14 14:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  8:41 Xiaoguang Wang
2021-09-14 13:42 ` Jens Axboe
2021-09-14 14:28   ` Xiaoguang Wang
2021-09-14 14:29     ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fe24a51-4d66-de57-add6-42cb5e980886@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=io-uring@vger.kernel.org \
    --cc=xiaoguang.wang@linux.alibaba.com \
    --subject='Re: [PATCH] io_uring: add missing sigmask restore in io_cqring_wait()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).