IO-Uring Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] io_uring: Add missing include <linux/highmem.h>
@ 2019-11-30  1:50 YueHaibing
  2019-11-30  2:53 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-11-30  1:50 UTC (permalink / raw)
  To: axboe, viro, asml.silence
  Cc: io-uring, linux-fsdevel, linux-kernel, YueHaibing

Fix build error:

fs/io_uring.c:1628:21: error: implicit declaration of function 'kmap' [-Werror=implicit-function-declaration]
fs/io_uring.c:1643:4: error: implicit declaration of function 'kunmap' [-Werror=implicit-function-declaration]

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 311ae9e159d8 ("io_uring: fix dead-hung for non-iter fixed rw")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 fs/io_uring.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 2c2e8c2..745eb00 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -69,6 +69,7 @@
 #include <linux/nospec.h>
 #include <linux/sizes.h>
 #include <linux/hugetlb.h>
+#include <linux/highmem.h>
 
 #define CREATE_TRACE_POINTS
 #include <trace/events/io_uring.h>
-- 
2.7.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] io_uring: Add missing include <linux/highmem.h>
  2019-11-30  1:50 [PATCH -next] io_uring: Add missing include <linux/highmem.h> YueHaibing
@ 2019-11-30  2:53 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-11-30  2:53 UTC (permalink / raw)
  To: YueHaibing, viro, asml.silence; +Cc: io-uring, linux-fsdevel, linux-kernel

On 11/29/19 5:50 PM, YueHaibing wrote:
> Fix build error:
> 
> fs/io_uring.c:1628:21: error: implicit declaration of function 'kmap' [-Werror=implicit-function-declaration]
> fs/io_uring.c:1643:4: error: implicit declaration of function 'kunmap' [-Werror=implicit-function-declaration]
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 311ae9e159d8 ("io_uring: fix dead-hung for non-iter fixed rw")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   fs/io_uring.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 2c2e8c2..745eb00 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -69,6 +69,7 @@
>   #include <linux/nospec.h>
>   #include <linux/sizes.h>
>   #include <linux/hugetlb.h>
> +#include <linux/highmem.h>
>   
>   #define CREATE_TRACE_POINTS
>   #include <trace/events/io_uring.h>

Fix for this is already queued up, and now sent to Linus as well:

https://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=aa4c3967756c6c576a38a23ac511be211462a6b7

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-30  1:50 [PATCH -next] io_uring: Add missing include <linux/highmem.h> YueHaibing
2019-11-30  2:53 ` Jens Axboe

IO-Uring Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/io-uring/0 io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ https://lore.kernel.org/io-uring \
		io-uring@vger.kernel.org
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.io-uring


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git