From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8466CC47434 for ; Thu, 8 Oct 2020 15:32:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F4B620782 for ; Thu, 8 Oct 2020 15:32:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="M+5QTSp4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731114AbgJHPc0 (ORCPT ); Thu, 8 Oct 2020 11:32:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731055AbgJHPcI (ORCPT ); Thu, 8 Oct 2020 11:32:08 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88E86C0613D2 for ; Thu, 8 Oct 2020 08:32:08 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id u19so6632994ion.3 for ; Thu, 08 Oct 2020 08:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RC21x8JZDkbxUW+NogUGgAglDCBQivF7vvLZcU4XCBk=; b=M+5QTSp4CppIsGYmXJM01fIlKfkO1PhhP+/at6Q9om+pM0zmeOaMVxE3Y/Jf6ituGZ 3LQOUV47FOwo+eA8+9zheIh/pmjWQz3FN8nCKURkvlAKyXHZYVpdP90X+uIR9UU2dmzU 8Nvq6PWO3wnANHsWDMNb5QHJG1S/anDkZsrOkj7751wJ8XNFKk3puP1FpALM9kAt5K7e CIC9ruCn0STDjjhlZOT9THMAZtvjgoj2FvX2/aOdrPF7UfZRWpYKxg/Z6b/QmaSpXwkq A7ABcVIqt/k66+g43JO/JIKkglc9nvDFyQqqBnzGhHVGl3IqZr5yoIIGY6azoNDGSPLd MWbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RC21x8JZDkbxUW+NogUGgAglDCBQivF7vvLZcU4XCBk=; b=gUmmEc+Js79/dczPLu6Qa8zpzgXyFjFOo/03tel56ytOTM+aiu09QLrutG0y/r5oJ5 Vo19++IqyJL1KdPTq5L+s9dRoIdShp0W/th8ZGvhm4Z7orXvZqeLJvIFynfIMzFsj6xj 5zTLqzAhOrmqJxn0yo5aKqlgm872W1G9WFwOs9yL0mAWjw5gX6yf11ogd9GzynR7JGCQ BmZ5P81QKl6qGx9h3znx375rh1GYTYGk+KOwDtaJnlV7caRqeYIaskZqq6fnJ+F68rnR PpVkS2myiHsjQGHVGK/FjfN4fYyL8Tk5wbENY2gASWGKtr/ywzNeRqTBCdKAXasmVWSO ZBWw== X-Gm-Message-State: AOAM533OvDeApXZ7UHMiO820i2i2n5mYh6WD9Ahhp795uPoKs5czjCKT 7LeiyCZAeFCii5zJgkxF4wKo4g== X-Google-Smtp-Source: ABdhPJyIMUBKswLqP41gFCa4J4UqBSjcxDgc7d8MFdW0VAjCMs/+fIVyLqoy5VnjY3nzBTjGxVmAfg== X-Received: by 2002:a02:6a49:: with SMTP id m9mr7169735jaf.43.1602171127855; Thu, 08 Oct 2020 08:32:07 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id q16sm2779202ilj.71.2020.10.08.08.32.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2020 08:32:07 -0700 (PDT) Subject: Re: inconsistent lock state in xa_destroy To: Matthew Wilcox Cc: syzbot , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk References: <00000000000045ac4605b12a1720@google.com> <20201008150518.GG20115@casper.infradead.org> <20201008152844.GI20115@casper.infradead.org> From: Jens Axboe Message-ID: <774b6b47-7c19-f2e9-588d-0f6bb363a2d7@kernel.dk> Date: Thu, 8 Oct 2020 09:32:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201008152844.GI20115@casper.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 10/8/20 9:28 AM, Matthew Wilcox wrote: > On Thu, Oct 08, 2020 at 09:06:56AM -0600, Jens Axboe wrote: >> On 10/8/20 9:05 AM, Matthew Wilcox wrote: >>> On Thu, Oct 08, 2020 at 09:01:57AM -0600, Jens Axboe wrote: >>>> On 10/8/20 9:00 AM, syzbot wrote: >>>>> Hello, >>>>> >>>>> syzbot found the following issue on: >>>>> >>>>> HEAD commit: e4fb79c7 Add linux-next specific files for 20201008 >>>>> git tree: linux-next >>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=12555227900000 >>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=568d41fe4341ed0f >>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=cdcbdc0bd42e559b52b9 >>>>> compiler: gcc (GCC) 10.1.0-syz 20200507 >>>>> >>>>> Unfortunately, I don't have any reproducer for this issue yet. >>>>> >>>>> IMPORTANT: if you fix the issue, please add the following tag to the commit: >>>>> Reported-by: syzbot+cdcbdc0bd42e559b52b9@syzkaller.appspotmail.com >>>> >>>> Already pushed out a fix for this, it's really an xarray issue where it just >>>> assumes that destroy can irq grab the lock. >>> >>> ... nice of you to report the issue to the XArray maintainer. >> >> This is from not even 12h ago, 10h of which I was offline. It wasn't on >> the top of my list of priority items to tackle this morning, but it >> is/was on the list. > > How's this? Looks like that'll do the trick in avoiding similar future lockdep splats for xa_destroy(). -- Jens Axboe