io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
	Stefan Metzmacher <metze@samba.org>,
	io-uring@vger.kernel.org
Subject: Re: [PATCH 0/2] send[msg]()/recv[msg]() fixes/improvements
Date: Wed, 17 Mar 2021 17:24:25 -0600	[thread overview]
Message-ID: <7ef8f70c-24a0-5218-ce18-3b0a354bf486@kernel.dk> (raw)
In-Reply-To: <b2f00537-a8a3-9243-6990-d6708e7f7691@gmail.com>

On 3/17/21 5:07 PM, Pavel Begunkov wrote:
> On 17/03/2021 22:36, Jens Axboe wrote:
>> On 3/16/21 9:33 AM, Stefan Metzmacher wrote:
>>> Hi,
>>>
>>> here're patches which fix linking of send[msg]()/recv[msg]() calls
>>> and make sure io_uring_enter() never generate a SIGPIPE.
> 
> 1/2 breaks userspace. Sounds like 2/2 might too, does it?

If they don't sever on short sends/receives, they cannot have been
used reliably by applications. So I don't think that's a real risk.

2/2 should just make it a reliable delivery, SIGPIPE would get
lost for async, amongst other things.

-- 
Jens Axboe


  reply	other threads:[~2021-03-17 23:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 15:33 [PATCH 0/2] send[msg]()/recv[msg]() fixes/improvements Stefan Metzmacher
2021-03-16 15:33 ` [PATCH 1/2] io_uring: call req_set_fail_links() on short send[msg]()/recv[msg]() calls Stefan Metzmacher
2021-03-20 19:33   ` [PATCH v2 1/1] io_uring: call req_set_fail_links() on short send[msg]()/recv[msg]() with MSG_WAITALL Stefan Metzmacher
2021-03-20 22:57     ` Jens Axboe
2021-03-21 10:20       ` Stefan Metzmacher
2021-03-21 13:10         ` Jens Axboe
2021-03-16 15:33 ` [PATCH 2/2] io_uring: imply MSG_NOSIGNAL for send[msg]()/recv[msg]() calls Stefan Metzmacher
2021-03-17 22:36 ` [PATCH 0/2] send[msg]()/recv[msg]() fixes/improvements Jens Axboe
2021-03-17 23:07   ` Pavel Begunkov
2021-03-17 23:24     ` Jens Axboe [this message]
2021-03-17 23:26     ` Stefan Metzmacher
2021-03-17 23:39       ` Pavel Begunkov
2021-03-18  0:15         ` Stefan Metzmacher
2021-03-18 13:00           ` Pavel Begunkov
2021-03-18 13:08           ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ef8f70c-24a0-5218-ce18-3b0a354bf486@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=io-uring@vger.kernel.org \
    --cc=metze@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).