io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hristo Venev <hristo@venev.name>
To: Dmitry Vyukov <dvyukov@google.com>, Jens Axboe <axboe@kernel.dk>
Cc: Necip Fazil Yildiran <necip@google.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring: fix sq array offset calculation
Date: Sat, 11 Jul 2020 18:52:19 +0300	[thread overview]
Message-ID: <7f128319f405358aa448a869a3a634a6cbc1469f.camel@venev.name> (raw)
In-Reply-To: <CACT4Y+YGwr+1k=rsJhMsnyQL4C+S2s9t7Cz5Axwc9fO5Ap4HbQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

On Sat, 2020-07-11 at 17:31 +0200, Dmitry Vyukov wrote:
> Looking at the code more, I am not sure how it may not corrupt
> memory.
> There definitely should be some combinations where accessing
> sq_entries*sizeof(u32) more memory won't be OK.
> May be worth adding a test that allocates all possible sizes for
> sq/cq
> and fills both rings.

The layout (after the fix) is roughly as follows:

1. struct io_rings - ~192 bytes, maybe 256
2. cqes - (32 << n) bytes
3. sq_array - (4 << n) bytes

The bug was that the sq_array was offset by (4 << n) bytes. I think
issues can only occur when

    PAGE_ALIGN(192 + (32 << n) + (4 << n) + (4 << n))
    !=
    PAGE_ALIGN(192 + (32 << n) + (4 << n))

It looks like this never happens. We got lucky.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 858 bytes --]

  parent reply	other threads:[~2020-07-11 15:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-11  9:31 [PATCH] io_uring: fix sq array offset calculation Dmitry Vyukov
2020-07-11  9:37 ` Hristo Venev
2020-07-11 15:15 ` Jens Axboe
2020-07-11 15:31   ` Dmitry Vyukov
2020-07-11 15:36     ` Jens Axboe
2020-07-11 15:47       ` Jens Axboe
2020-07-11 15:52     ` Hristo Venev [this message]
2020-07-11 15:55       ` Jens Axboe
2020-07-11 15:56       ` Hristo Venev
2020-07-11 16:16       ` Dmitry Vyukov
2020-07-17 13:48         ` Dmitry Vyukov
2020-07-17 14:05           ` Jens Axboe
2020-07-17 14:08             ` Jens Axboe
2020-07-17 14:08             ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f128319f405358aa448a869a3a634a6cbc1469f.camel@venev.name \
    --to=hristo@venev.name \
    --cc=axboe@kernel.dk \
    --cc=dvyukov@google.com \
    --cc=io-uring@vger.kernel.org \
    --cc=necip@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).