From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A62C4361B for ; Sat, 19 Dec 2020 23:46:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DAB0233FE for ; Sat, 19 Dec 2020 23:46:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726449AbgLSXqU (ORCPT ); Sat, 19 Dec 2020 18:46:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726421AbgLSXqT (ORCPT ); Sat, 19 Dec 2020 18:46:19 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00C05C0613CF for ; Sat, 19 Dec 2020 15:45:38 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id t16so6954981wra.3 for ; Sat, 19 Dec 2020 15:45:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=STWUWGh4FrhDASxqeG4Z0UWqq3BwJgSqv6pDFrQPnBA=; b=tHN7SHJC0iPXpYJXbcRdVcLmI/20cQYyamPvH3Qy/HPAZyi2QkHNor3NFitSx2sLYj gnD3mcPW2jfceVY0oNb+be3QiOevhW2uaIij5Z6To7WXFR3JCo2zwJ0OEuvAisS63HUH +WF0KJrpwJilYtkCwe3cWFiDXhEQripbXohzTEA2syThDzlOMQgRwcdCSz5epCt4HkAM RaX/Y5zLgLBdyP8DLpnCnyvI4LI8RpxrsuwMs02v0YfyPchKyYqy6He+JoftVw+aAuSk fwJRXyhwINKPxNAyQ4POH8BXfmLw9eixpt4ugCgaqdLVziPsdbll0QUItzG/pg0P/33j eK3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=STWUWGh4FrhDASxqeG4Z0UWqq3BwJgSqv6pDFrQPnBA=; b=eBBc2BqKF7EUvcqR2Q1DrbA62Ia/375sAbcaM30Rncir3Ni6N20ROX7+L4cQNbmcy3 mfll9gie7b4+wKat6e9eX98K/Om3AOct6NNKvvIjs1hbx6Eo1+gkVVTwpeXCttZn9cUq idyJsV5A41WCr6H3OMgE62WwCR32jYv8yhqB2Q4x+hR9HoP3Zwi8KbFsHtnsCM8FDcAw /JoV1IciMAzHZpvfDD7IDvD/dlI/pCCmZNqLbacTm0m2v2DLHp7u6+MOhCt+CfsAGhZn 2IqMU9XMS0qxrWHbOJ3f6OftOJE0aby2oV2u4jZestx4o8o6MopjqQHqxIMAJOm/LsNY /v1Q== X-Gm-Message-State: AOAM532+7DiadY4f4Q6Fme9F+tK55R/wKv8XB6qZg+ZP8dexU35a6nSe 8xFQFsm9W3T/cm4kCZwxoYTXxJqZb2ZVqA== X-Google-Smtp-Source: ABdhPJzPjs4puOjdl4rAAF+Y7jVthMJz0JuOatVCg08sAJic9cI+uHhHXiMpc4OBkr0aSuEo/m2hng== X-Received: by 2002:adf:c387:: with SMTP id p7mr11187699wrf.95.1608421537410; Sat, 19 Dec 2020 15:45:37 -0800 (PST) Received: from [192.168.8.133] ([85.255.237.164]) by smtp.gmail.com with ESMTPSA id m81sm17296081wmf.29.2020.12.19.15.45.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Dec 2020 15:45:36 -0800 (PST) To: Jens Axboe , Josef Cc: Norman Maurer , Dmitry Kadashev , io-uring References: <4dc9c74b-249d-117c-debf-4bb9e0df2988@kernel.dk> <2B352D6C-4CA2-4B09-8751-D7BB8159072D@googlemail.com> <0fe708e2-086b-94a8-def4-e4ebd6e0b709@kernel.dk> <614f8422-3e0e-25b9-4cc2-4f1c07705ab0@kernel.dk> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Subject: Re: "Cannot allocate memory" on ring creation (not RLIMIT_MEMLOCK) Message-ID: <986c85af-bb77-60d4-8739-49b662554157@gmail.com> Date: Sat, 19 Dec 2020 23:42:16 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <614f8422-3e0e-25b9-4cc2-4f1c07705ab0@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 19/12/2020 23:13, Jens Axboe wrote: > On 12/19/20 2:54 PM, Jens Axboe wrote: >> On 12/19/20 1:51 PM, Josef wrote: >>>> And even more so, it's IOSQE_ASYNC on the IORING_OP_READ on an eventfd >>>> file descriptor. You probably don't want/mean to do that as it's >>>> pollable, I guess it's done because you just set it on all reads for the >>>> test? >>> >>> yes exactly, eventfd fd is blocking, so it actually makes no sense to >>> use IOSQE_ASYNC >> >> Right, and it's pollable too. >> >>> I just tested eventfd without the IOSQE_ASYNC flag, it seems to work >>> in my tests, thanks a lot :) >>> >>>> In any case, it should of course work. This is the leftover trace when >>>> we should be exiting, but an io-wq worker is still trying to get data >>>> from the eventfd: >>> >>> interesting, btw what kind of tool do you use for kernel debugging? >> >> Just poking at it and thinking about it, no hidden magic I'm afraid... > > Josef, can you try with this added? Looks bigger than it is, most of it > is just moving one function below another. Hmm, which kernel revision are you poking? Seems it doesn't match io_uring-5.10, and for 5.11 io_uring_cancel_files() is never called with NULL files. if (!files) __io_uring_cancel_task_requests(ctx, task); else io_uring_cancel_files(ctx, task, files); > diff --git a/fs/io_uring.c b/fs/io_uring.c > index f3690dfdd564..96f6445ab827 100644 > --- a/fs/io_uring.c > +++ b/fs/io_uring.c > @@ -8735,10 +8735,43 @@ static void io_cancel_defer_files(struct io_ring_ctx *ctx, [...] > static void io_uring_cancel_files(struct io_ring_ctx *ctx, > struct task_struct *task, > struct files_struct *files) > { > + /* files == NULL, task is exiting. Cancel all that match task */ > + if (!files) > + __io_uring_cancel_task_requests(ctx, task); > + For 5.11 I believe it should look like diff --git a/fs/io_uring.c b/fs/io_uring.c index f3690dfdd564..38fb351cc1dd 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -8822,9 +8822,8 @@ static void io_uring_cancel_task_requests(struct io_ring_ctx *ctx, io_cqring_overflow_flush(ctx, true, task, files); io_ring_submit_unlock(ctx, (ctx->flags & IORING_SETUP_IOPOLL)); - if (!files) - __io_uring_cancel_task_requests(ctx, task); - else + __io_uring_cancel_task_requests(ctx, task); + if (files) io_uring_cancel_files(ctx, task, files); if ((ctx->flags & IORING_SETUP_SQPOLL) && ctx->sq_data) { -- Pavel Begunkov