io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Hao Xu <haoxu@linux.alibaba.com>, Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH for-5.15 v3 0/2] fix failed linkchain code logic
Date: Fri, 27 Aug 2021 12:01:20 +0100	[thread overview]
Message-ID: <99ef07a1-d072-5970-6c9a-df388026a01e@gmail.com> (raw)
In-Reply-To: <20210827094609.36052-1-haoxu@linux.alibaba.com>

On 8/27/21 10:46 AM, Hao Xu wrote:
> the first patch is code clean.
> the second is the main one, which refactors linkchain failure path to
> fix a problem, detail in the commit message.

Looks good, thanks

Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>

> v1-->v2
>  - update patch with Pavel's suggestion.
> v2-->v3
>  - move req->result initiation to better place
>  - add helpers for failing link node
> 
> Hao Xu (2):
>   io_uring: remove redundant req_set_fail()
>   io_uring: fix failed linkchain code logic
> 
>  fs/io_uring.c | 62 ++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 47 insertions(+), 15 deletions(-)
> 

-- 
Pavel Begunkov

  parent reply	other threads:[~2021-08-27 11:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27  9:46 [PATCH for-5.15 v3 0/2] fix failed linkchain code logic Hao Xu
2021-08-27  9:46 ` [PATCH 1/2] io_uring: remove redundant req_set_fail() Hao Xu
2021-08-27  9:46 ` [PATCH 2/2] io_uring: fix failed linkchain code logic Hao Xu
2021-08-27 11:01 ` Pavel Begunkov [this message]
2021-08-27 13:27 ` [PATCH for-5.15 v3 0/2] " Jens Axboe
2021-08-27 17:04   ` Hao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99ef07a1-d072-5970-6c9a-df388026a01e@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=haoxu@linux.alibaba.com \
    --cc=io-uring@vger.kernel.org \
    --cc=joseph.qi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).