From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: io-uring@vger.kernel.org, david@fromorbit.com
Subject: Re: [PATCHSET 0/2] io_uring: handle short reads internally
Date: Thu, 13 Aug 2020 14:37:30 -0600 [thread overview]
Message-ID: <9f050b83-a64a-c112-fc26-309342076c71@kernel.dk> (raw)
In-Reply-To: <99c39782-6523-ae04-3d48-230f40bc5d05@kernel.dk>
On 8/13/20 2:33 PM, Jens Axboe wrote:
> On 8/13/20 2:25 PM, Jeff Moyer wrote:
>> Jens Axboe <axboe@kernel.dk> writes:
>>
>>> Since we've had a few cases of applications not dealing with this
>>> appopriately, I believe the safest course of action is to ensure that
>>> we don't return short reads when we really don't have to.
>>>
>>> The first patch is just a prep patch that retains iov_iter state over
>>> retries, while the second one actually enables just doing retries if
>>> we get a short read back.
>>
>> Have you run this through the liburing regression tests?
>>
>> Tests <eeed8b54e0df-test> <timeout-overflow> <read-write> failed
>>
>> I'll take a look at the failures, but wanted to bring it to your
>> attention sooner rather than later. I was using your io_uring-5.9
>> branch.
>
> The eed8b54e0df-test failure is known with this one, pretty sure it
> was always racy, but I'm looking into it.
>
> The timeout-overflow test needs fixing, it's just an ordering thing
> with the batched completions done through submit. Not new with these
> patches.
>
> The read-write one I'm interested in, what did you run it on? And
> what was the failure?
BTW, what git sha did you run?
--
Jens Axboe
next prev parent reply other threads:[~2020-08-13 20:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 17:56 [PATCHSET 0/2] io_uring: handle short reads internally Jens Axboe
2020-08-13 17:56 ` [PATCH 1/2] io_uring: retain iov_iter state over io_read/io_write calls Jens Axboe
2020-08-13 17:56 ` [PATCH 2/2] io_uring: internally retry short reads Jens Axboe
2020-08-13 20:25 ` [PATCHSET 0/2] io_uring: handle short reads internally Jeff Moyer
2020-08-13 20:33 ` Jens Axboe
2020-08-13 20:37 ` Jens Axboe [this message]
2020-08-13 20:41 ` Jens Axboe
2020-08-13 20:49 ` Jeff Moyer
2020-08-13 22:08 ` Jens Axboe
2020-08-13 22:21 ` Jeff Moyer
2020-08-13 22:31 ` Jens Axboe
2020-08-17 20:55 ` Jeff Moyer
2020-08-17 20:57 ` Jens Axboe
2020-08-18 17:55 ` Jeff Moyer
2020-08-18 18:00 ` Jens Axboe
2020-08-18 18:07 ` Jeff Moyer
2020-08-18 18:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f050b83-a64a-c112-fc26-309342076c71@kernel.dk \
--to=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=io-uring@vger.kernel.org \
--cc=jmoyer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).