From: Josef <josef.grieb@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>
Cc: norman@apache.org
Subject: Re: io_uring process termination/killing is not working
Date: Sun, 16 Aug 2020 23:09:10 +0200 [thread overview]
Message-ID: <CAAss7+qHUNSX7xxQE6L1Upc2jYj-jLPaGMH+O1e30oF2nrmjCw@mail.gmail.com> (raw)
In-Reply-To: <b35ac93e-cf5f-ee98-404d-358674d51075@kernel.dk>
> BTW, something I think you're aware of, but wanted to bring up
> explicitly - if IORING_FEAT_FAST_POLL is available in the ring features,
> then you generally don't want/need to link potentially blocking requests
> on pollable files with a poll in front. io_uring will do this
> internally, and save you an sqe and completion event for each of these
> types of requests.
>
> Your test case is a perfect example of that, neither the accept nor the
> socket read would need a poll linked in front of them, as they are both
> pollable file types and will not trigger use of an async thread to wait
> for the event. Instead an internal poll is armed which will trigger the
> issue of that request, when the socket is ready.
I agree as well I don't need a poll linked in font of read event, but
not for the non blocking accept event because of this fix in Linux
5.8:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.8&id=e697deed834de15d2322d0619d51893022c90ea2
I receive an immediate response to tell if there's ever any data
there, same behaviour like accept non blocking socket, that’s why I
use poll link to avoid that
--
Josef Grieb
next prev parent reply other threads:[~2020-08-16 21:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 17:58 io_uring process termination/killing is not working Josef
2020-08-12 18:05 ` Jens Axboe
2020-08-12 18:20 ` Pavel Begunkov
2020-08-12 18:22 ` Pavel Begunkov
2020-08-12 18:28 ` Pavel Begunkov
2020-08-12 23:32 ` Jens Axboe
2020-08-13 16:07 ` Josef
2020-08-13 16:09 ` Jens Axboe
2020-08-15 7:45 ` Pavel Begunkov
2020-08-15 15:12 ` Jens Axboe
2020-08-15 16:48 ` Pavel Begunkov
2020-08-15 21:43 ` Josef
2020-08-15 22:35 ` Jens Axboe
2020-08-15 23:21 ` Josef
2020-08-15 23:31 ` Jens Axboe
2020-08-16 0:36 ` Josef
2020-08-16 0:41 ` Jens Axboe
2020-08-16 1:21 ` Jens Axboe
2020-08-16 3:14 ` Josef
2020-08-16 3:20 ` Jens Axboe
2020-08-16 17:30 ` Jens Axboe
2020-08-16 21:09 ` Josef [this message]
2020-08-16 22:17 ` Jens Axboe
2020-08-17 8:58 ` Josef
2020-08-17 10:08 ` Pavel Begunkov
2020-08-16 13:45 ` Jens Axboe
2020-08-16 14:53 ` Jens Axboe
2020-08-16 15:22 ` Jens Axboe
2020-08-17 10:16 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAss7+qHUNSX7xxQE6L1Upc2jYj-jLPaGMH+O1e30oF2nrmjCw@mail.gmail.com \
--to=josef.grieb@gmail.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=norman@apache.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).