From: Ammar Faizi <ammar.faizi@students.amikom.ac.id>
To: Louvian Lyndal <louvianlyndal@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
io-uring Mailing List <io-uring@vger.kernel.org>,
Ammar Faizi <ammarfaizi2@gmail.com>
Subject: Re: [PATCHSET v1 RFC liburing 0/6] Implement the kernel style return value
Date: Fri, 1 Oct 2021 14:36:34 +0700 [thread overview]
Message-ID: <CAGzmLMVKZMjzfyNX2NNEzU8J4wXqUKhghbZH7=Wh=Ldsb3Cy3A@mail.gmail.com> (raw)
In-Reply-To: <89cf843d-be43-4bd6-0e20-4fb04a500512@gmail.com>
On Fri, Oct 1, 2021 at 1:44 PM Louvian Lyndal <louvianlyndal@gmail.com> wrote:
> This will add extra call just to wrap the libc. Consider to static
> inline them?
>
> For libc they just check the retval, if it's -1 then return -errno. If
> they are inlined, they are ideally identical with the previous version.
>
> Besides they are all internal functions. I don't see why should we
> pollute global scope with extra wrappers.
>
Yeah makes sense, I will address this for v2. We can have them as
static inline functions in `src/syscall.h`.
> Regards,
>
> --
> Louvian Lyndal
prev parent reply other threads:[~2021-10-01 7:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 10:16 [PATCHSET v1 RFC liburing 0/6] Implement the kernel style return value Ammar Faizi
2021-09-29 10:16 ` [PATCHSET v1 RFC liburing 1/6] src/syscall: " Ammar Faizi
2021-09-29 10:16 ` [PATCHSET v1 RFC liburing 2/6] Add kernel error header `src/kernel_err.h` Ammar Faizi
2021-09-29 10:16 ` [PATCHSET v1 RFC liburing 3/6] Add `liburing_mmap()` and `liburing_munmap()` Ammar Faizi
2021-09-29 10:16 ` [PATCHSET v1 RFC liburing 4/6] Add `liburing_madvise()` Ammar Faizi
2021-09-29 10:16 ` [PATCHSET v1 RFC liburing 5/6] Add `liburing_getrlimit()` and `liburing_setrlimit()` Ammar Faizi
2021-09-29 10:16 ` [PATCHSET v1 RFC liburing 6/6] src/{queue,register,setup}: Remove `#include <errno.h>` Ammar Faizi
2021-09-29 10:21 ` [PATCHSET v1 RFC liburing 0/6] Implement the kernel style return value Ammar Faizi
2021-10-01 6:44 ` Louvian Lyndal
2021-10-01 7:36 ` Ammar Faizi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGzmLMVKZMjzfyNX2NNEzU8J4wXqUKhghbZH7=Wh=Ldsb3Cy3A@mail.gmail.com' \
--to=ammar.faizi@students.amikom.ac.id \
--cc=ammarfaizi2@gmail.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=louvianlyndal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).