From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dmitry Kadashev <dkadashev@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <christian.brauner@ubuntu.com>,
Pavel Begunkov <asml.silence@gmail.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH v8 05/11] fs: make do_mknodat() take struct filename
Date: Wed, 7 Jul 2021 12:22:06 -0700 [thread overview]
Message-ID: <CAHk-=wiG+sN+2zSoAOggKCGue2kOJvw3rQySvQXsZstRQFTN+g@mail.gmail.com> (raw)
In-Reply-To: <20210707122747.3292388-6-dkadashev@gmail.com>
On Wed, Jul 7, 2021 at 5:28 AM Dmitry Kadashev <dkadashev@gmail.com> wrote:
>
> Pass in the struct filename pointers instead of the user string, for
> uniformity with the recently converted do_unlinkat(), do_renameat(),
> do_mkdirat().
Yup. And the uniformity continues with that "we could avoid the goto
retry/out1 with a mknodat_helper() function for the inner meat of the
function.
Linus
next prev parent reply other threads:[~2021-07-07 19:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 12:27 [PATCH v8 00/11] io_uring: add mkdir and [sym]linkat support Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 01/11] namei: ignore ERR/NULL names in putname() Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 02/11] namei: change filename_parentat() calling conventions Dmitry Kadashev
2021-07-07 19:18 ` Linus Torvalds
2021-07-07 12:27 ` [PATCH v8 03/11] fs: make do_mkdirat() take struct filename Dmitry Kadashev
2021-07-07 19:20 ` Linus Torvalds
2021-07-07 12:27 ` [PATCH v8 04/11] io_uring: add support for IORING_OP_MKDIRAT Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 05/11] fs: make do_mknodat() take struct filename Dmitry Kadashev
2021-07-07 19:22 ` Linus Torvalds [this message]
2021-07-07 12:27 ` [PATCH v8 06/11] fs: make do_symlinkat() " Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 07/11] namei: add getname_uflags() Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 08/11] fs: make do_linkat() take struct filename Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 09/11] fs: update do_*() helpers to return ints Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 10/11] io_uring: add support for IORING_OP_SYMLINKAT Dmitry Kadashev
2021-07-07 12:27 ` [PATCH v8 11/11] io_uring: add support for IORING_OP_LINKAT Dmitry Kadashev
2021-07-07 12:32 ` [PATCH v8 00/11] io_uring: add mkdir and [sym]linkat support Dmitry Kadashev
2021-07-07 19:26 ` Linus Torvalds
2021-07-08 6:05 ` Dmitry Kadashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiG+sN+2zSoAOggKCGue2kOJvw3rQySvQXsZstRQFTN+g@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=christian.brauner@ubuntu.com \
--cc=dkadashev@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).