IO-Uring Archive on
 help / color / Atom feed
From: Linus Torvalds <>
To: Jens Axboe <>
Cc: io-uring <>,
	"" <>
Subject: Re: [GIT PULL] io_uring fixes for 5.6-rc2
Date: Fri, 14 Feb 2020 14:07:48 -0800
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Feb 14, 2020 at 8:45 AM Jens Axboe <> wrote:
> Here's a set of fixes for io_uring that should go into this release.


          for_each_node(node) {
+                if (!node_online(node))
+                        continue;

that's just silly.

We have 'for_each_online_node()' for this.

There's something like four patterns of that pointless thing.

And in io_wq_create(), do you really want to allocate that wqe for
nodes that aren't online? Right now you _allocate_ the node data for
them (using a non-node-specific allocation), but then you won't
actually create the thread for them io_wq_manager().

Plus if the node online status changes, it looks like you'll mess up
_anyway_, in that  io_wq_manager() will first create the workers on
one set of nodes, but then perhaps set the state flags for a
completely different set of nodes if some onlining/offlining has

I've pulled this, but Jens, you need to be more careful. This all
looks like completely random state that nobody spent any time thinking

Seriously, this "io_uring FIXES ONLY" needs to be stricter than what
you seem to be doing here. This "fix" is opening up a lot of new
possibilities for inconsistencies in the data structures.


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 16:45 Jens Axboe
2020-02-14 22:07 ` Linus Torvalds [this message]
2020-02-15  1:20   ` Jens Axboe
2020-02-15 18:40 ` pr-tracker-bot

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IO-Uring Archive on

Archives are clonable:
	git clone --mirror io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ \
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone