From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16840C2D0C2 for ; Sat, 4 Jan 2020 16:42:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5FB82464E for ; Sat, 4 Jan 2020 16:42:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FNV05je6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726016AbgADQmD (ORCPT ); Sat, 4 Jan 2020 11:42:03 -0500 Received: from mail-lf1-f50.google.com ([209.85.167.50]:41917 "EHLO mail-lf1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbgADQmD (ORCPT ); Sat, 4 Jan 2020 11:42:03 -0500 Received: by mail-lf1-f50.google.com with SMTP id m30so33783166lfp.8 for ; Sat, 04 Jan 2020 08:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q0ceMoCPztD9uTw7IE7HZ0U64QBBiKyEpyIeEKtrKlk=; b=FNV05je6bqXENfvcwCw5YpitnPtNivG5ELdiDBrPCQTWP2IioLgPt0JCO4It4bPWTL td2Wvfr4rlaz5tlY/PAMEoxOsGPzEgWHwZME4LOBuJ1xU06x/iRTrDUx2RZlHEjHbTFo OW0J5KlluvOQC0Prru349fjk1YyYamnSielhWSxhhttiYI+4MTjQ2cwN7rDK5zT9i1uP ESmNMIL34S0B5o6hVTVmF5YwP4pKOQ3nooDbJMyoEkVsl55E9aEAVfA5otquh7w/63FP J2Kykr/ol2f90QGUYsfB+VREiL8hQX7BjOAGBWuwWnORWuW3I/U1E6EHCmPRr6n/GUDZ Mpkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q0ceMoCPztD9uTw7IE7HZ0U64QBBiKyEpyIeEKtrKlk=; b=h/e8dbe8Xg9yoX0+kkmtDdfNGHDSUuCcLXX7S8xIj167Ja8h+qzSF79DLPXv/vR/SY 3oMglR+kimcIVOkf4YlShE4fEKRR+R4D078A/Bi4S/Pb7eXqMiKtQedHwfr+VUa8vJZC Lm+ETP/LrgBNS08vpv7nrzlFBxQBjMrsb+0fB/7ZojxlnE62nSebdCO7HUXSl40nA7Fy zO+JtjTh6dFcXw4+SYbmsbd81il92bW3yEbenpYO6NdvlbzGJ6TMUGOI0k/f8EviaN9y cQWrGlMtqrOq6yYB8ocnyQO9hUqFUppFlMw0r4MxUGGxG9yuqMNM7DJ279sw/yXNt+AI vdiQ== X-Gm-Message-State: APjAAAXGpuY4KXP682HYMsTA/i/1as/BpxEV/V2z2+S1oVdKOEgGKsy8 QzSjT/ZKkr2GeBFDXrzQO6CAWUFd+YR29WRZ0aEUhnC8 X-Google-Smtp-Source: APXvYqy37FNl5UPNwI6lSWGYqRX2FVHn8G7o1QlKfOqiWzrTvhT7t9N3jl5HnmtqRrHu+SeCen5Mh+hHhGABb/MTL3c= X-Received: by 2002:a19:f701:: with SMTP id z1mr52056588lfe.13.1578156121008; Sat, 04 Jan 2020 08:42:01 -0800 (PST) MIME-Version: 1.0 References: <20200104162211.9008-1-wdauchy@gmail.com> In-Reply-To: From: William Dauchy Date: Sat, 4 Jan 2020 17:41:50 +0100 Message-ID: Subject: Re: SQPOLL behaviour with openat To: Jens Axboe Cc: io-uring@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Hello Jens, Thank you for the quick answer. On Sat, Jan 4, 2020 at 5:28 PM Jens Axboe wrote: > sqpoll requires the use of fixed files for any sqe, at least for now. > That's why it returns -EBADF if the request doesn't have fixed files > specified. I indeed forgot sqe->flags |= IOSQE_FIXED_FILE; in my modified test. > So it cannot be used with opcodes that create (or close) file > descriptors either. ok, I thought `dirfd` could have been the index of my registered fd for `openat` call. It was not very clear to me this was not possible to use fixed files for those opcodes. Thanks, -- William