From: Victor Stewart <v@nametag.social>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring <io-uring@vger.kernel.org>
Subject: Re: bug with fastpoll accept and sqpoll + IOSQE_FIXED_FILE
Date: Tue, 2 Feb 2021 12:30:34 -0500 [thread overview]
Message-ID: <CAM1kxwgOwWhv=O_vOpyQfca-9Vjo4+SrmxPR5MxTGf_9pE4_Gg@mail.gmail.com> (raw)
In-Reply-To: <8a3ba4fc-6e60-a3e7-69f4-0394799e7fd7@gmail.com>
> There is a change of behaviour, if IORING_FEAT_EXT_ARG is set it
> won't submit (IIRC, since 5.12) -- it's pretty important for some
> multi-threaded cases.
>
> So... where in particular does it say that? In case your liburing
> is up to date and we forgot to remove such a comment.
https://github.com/axboe/liburing/blob/c96202546bd9d7420d97bc05e73c7144d0924e8a/src/queue.c#L269
"For kernels without IORING_FEAT_EXT_ARG (5.10 and older), if 'ts' is
specified, the application need not call io_uring_submit() before
calling this function, as we will do that on its behalf."
and I'm using the latest Clear Linux kernel which is 5.10, so that's
why I wasn't submitting.
next prev parent reply other threads:[~2021-02-02 17:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 5:36 bug with fastpoll accept and sqpoll + IOSQE_FIXED_FILE Victor Stewart
2021-02-02 11:05 ` Pavel Begunkov
2021-02-02 11:23 ` Pavel Begunkov
2021-02-02 16:18 ` Victor Stewart
2021-02-02 16:30 ` Victor Stewart
2021-02-02 16:44 ` Jens Axboe
2021-02-02 17:10 ` Victor Stewart
2021-02-02 17:24 ` Jens Axboe
2021-02-02 17:41 ` Pavel Begunkov
2021-02-02 20:34 ` Pavel Begunkov
2021-02-02 20:48 ` Jens Axboe
2021-02-02 20:56 ` Pavel Begunkov
2021-02-03 11:49 ` Pavel Begunkov
2021-02-04 16:50 ` Jens Axboe
2021-02-05 12:46 ` Pavel Begunkov
2021-02-05 14:42 ` Jens Axboe
2021-02-05 14:49 ` Pavel Begunkov
2021-02-02 17:46 ` Jens Axboe
2021-02-02 17:50 ` Victor Stewart
2021-02-02 17:57 ` Jens Axboe
2021-02-02 17:46 ` Victor Stewart
2021-02-02 17:21 ` Pavel Begunkov
2021-02-02 17:30 ` Victor Stewart [this message]
2021-02-02 17:45 ` Victor Stewart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM1kxwgOwWhv=O_vOpyQfca-9Vjo4+SrmxPR5MxTGf_9pE4_Gg@mail.gmail.com' \
--to=v@nametag.social \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).