From: Victor Stewart <v@nametag.social>
To: Stefan Metzmacher <metze@samba.org>, io-uring <io-uring@vger.kernel.org>
Subject: Re: [RFC 0/1] whitelisting UDP GSO and GRO cmsgs
Date: Sat, 28 Nov 2020 19:03:22 +0000 [thread overview]
Message-ID: <CAM1kxwh1A3Fh6g7C=kxr67JLF325Cw5jY6CoL6voNhboV1wsVw@mail.gmail.com> (raw)
In-Reply-To: <5d71d36c-0bfb-a313-07e8-0e22f7331a7a@samba.org>
On Thu, Nov 26, 2020 at 7:36 AM Stefan Metzmacher <metze@samba.org> wrote:
>
> Am 23.11.20 um 17:29 schrieb Victor Stewart:
> > On Mon, Nov 23, 2020 at 4:13 PM Stefan Metzmacher <metze@samba.org> wrote:
> >>
> >> Hi Victor,
> >>
> >> wouldn't it be enough to port the PROTO_CMSG_DATA_ONLY check to the sendmsg path?
> >>
> >> UDP sockets should have PROTO_CMSG_DATA_ONLY set.
> >>
> >> I guess that would fix your current problem.
> >
> > that would definitely solve the problem and is the easiest solution.
> >
> > but PROTO_CMSG_DATA_ONLY is only set on inet_stream_ops and
> > inet6_stream_ops but dgram?
>
> I guess PROTO_CMSG_DATA_ONLY should be added also for dgram sockets.
>
> Did you intend to remove the cc for the mailing list?
>
> I think in addition to the io-uring list, cc'ing netdev@vger.kernel.org
> would also be good.
whoops forgot to reply all.
before I CC netdev, what does PROTO_CMSG_DATA_ONLY actually mean? I
didn't find a clear explanation anywhere by searching the kernel, only
that it was defined as 1 and flagged on inet_stream_ops and
inet6_stream_ops.
there must be a reason it was not initially included for dgrams?
but yes if there's nothing standing in the way of adding it for
dgrams, and it covers UDP_SEGMENT and UDP_GRO then that's of course
the least friction solution here.
>
> metze
>
>
next prev parent reply other threads:[~2020-11-28 22:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 15:29 [RFC 0/1] whitelisting UDP GSO and GRO cmsgs Victor Stewart
2020-11-23 16:13 ` Stefan Metzmacher
[not found] ` <CAM1kxwhUcXLKU=2hCVaBngOKRL_kgMX4ONy9kpzKW+ZBZraEYw@mail.gmail.com>
[not found] ` <5d71d36c-0bfb-a313-07e8-0e22f7331a7a@samba.org>
2020-11-28 19:03 ` Victor Stewart [this message]
2020-11-30 10:52 ` Stefan Metzmacher
2020-11-30 14:57 ` Soheil Hassas Yeganeh
2020-11-30 15:05 ` Stefan Metzmacher
2020-11-30 15:15 ` Soheil Hassas Yeganeh
2020-11-30 16:17 ` Victor Stewart
2020-11-30 16:20 ` Soheil Hassas Yeganeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM1kxwh1A3Fh6g7C=kxr67JLF325Cw5jY6CoL6voNhboV1wsVw@mail.gmail.com' \
--to=v@nametag.social \
--cc=io-uring@vger.kernel.org \
--cc=metze@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).