From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F781C2D0E4 for ; Mon, 23 Nov 2020 15:29:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2A1E20782 for ; Mon, 23 Nov 2020 15:29:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nametag.social header.i=@nametag.social header.b="y48mn3l3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732037AbgKWP3W (ORCPT ); Mon, 23 Nov 2020 10:29:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727444AbgKWP3W (ORCPT ); Mon, 23 Nov 2020 10:29:22 -0500 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D325CC0613CF for ; Mon, 23 Nov 2020 07:29:21 -0800 (PST) Received: by mail-ej1-x643.google.com with SMTP id o21so23843481ejb.3 for ; Mon, 23 Nov 2020 07:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nametag.social; s=google; h=mime-version:from:date:message-id:subject:to; bh=tlSZHhBEU9+4NRbdMZQRiRMCi9ZBf218EK+Z/G0F10g=; b=y48mn3l3NI+Wwf1vUavZIVnpOid1VURK0zL7MgInuuaJzJRZLG/t/kYlIqZtMzd3SF E5HH2F7j3Txm+mLJ/405brikIWMXPs2GjQwF7XLhJP6qOpBulxGsq1v2/YKdzFN0ba8b XKIgNlhg3I03jVgdWecnBShxYl5XIriDejFBu6cxY1+Y+A45sXJrlAvkUHahL/8Mwbnf 9bR2XLW/bvSxHQFAqprgHxDZPEwIgWGwT+6J3RjdcDncCVAKhgSuSSRCfeMgoMhXl+6F uU6Q0brnnT9i6C8lk1QvK8rbFEUpRo9aAnsfQyN/xZvXq+EBIQYzFlsTlT1giM0knXe4 s50A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=tlSZHhBEU9+4NRbdMZQRiRMCi9ZBf218EK+Z/G0F10g=; b=GK36JXOKWeIpGom8NM3tcN7dHbqDf8w5/TbOa9NQ8sNdWqu0LxD7fDMg6LgNBMKIfX fBDhQTWhsPUDmvLpu8RqrVuHr1JKBDi8El0Giee9iahgEDCRTLKba68bT1QC4FUgOlju chGl0DQ0LOUYWTdfZ+9Wwxm31qJN0JA/Ybq9S+LEB50o6iciG5Zgv1UJ8AE+71f8dbhr smqkJPUchdUZ/aswXUbqBpTSxbNS27L5CupNF6fZIDaJdDtB02QFNV4k6mAmb6j8K+3A odE5/GUZ0GelT55TDYBTculYQpxLX75+w0TCW2C4lXMaqrXn+xPSnvcGkzZPWQF1hiRC CzVA== X-Gm-Message-State: AOAM531UhRIIq7+NvntlTwtHW7EjYqf64xLduTFO8B6oHy+sckNwvWqZ xNQyYqqefCF5YV+wFOZIZlyOdJOpbAeP+wmpu1/lEHYJmaPjMeFR X-Google-Smtp-Source: ABdhPJy09RaVHdWFmoel7qFFR6c/2FdxQ8DpXsx6tKacFdbxdVmRIw+Vh2gGgOGLbqncR1aNJBHuBZF2HuunJfNUCoo= X-Received: by 2002:a17:906:f14c:: with SMTP id gw12mr110904ejb.261.1606145360188; Mon, 23 Nov 2020 07:29:20 -0800 (PST) MIME-Version: 1.0 From: Victor Stewart Date: Mon, 23 Nov 2020 15:29:09 +0000 Message-ID: Subject: [RFC 0/1] whitelisting UDP GSO and GRO cmsgs To: io-uring , Jens Axboe Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org so currently all cmsg headers are disabled through sendmsg and recvmsg operations through io_uring because of https://www.exploit-db.com/exploits/47779 i think it's time we start whitelisting the good guys though? GSO and GRO are hugely important for QUIC servers, and together offer a higher throughput gain than io_uring alone (rate of data transit considering), thus io_uring is the lesser performance choice for QUIC servers at the moment. RE http://vger.kernel.org/lpc_net2018_talks/willemdebruijn-lpc2018-udpgso-paper-DRAFT-1.pdf, GSO is about +~63% and GRO +~82%. this patch closes that loophole. Victor Stewart (1); net/socket.c: add __sys_whitelisted_cmsghdrs() net/socket.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)