From: Dmitry Kadashev <dkadashev@gmail.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Pavel Begunkov <asml.silence@gmail.com>,
linux-fsdevel@vger.kernel.org,
io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] fs: make do_mkdirat() take struct filename
Date: Wed, 31 Mar 2021 17:43:50 +0700 [thread overview]
Message-ID: <CAOKbgA4eAYE1aDBU3WJumnz8aUoF23qOD32F_OtwE=qCXRSxeA@mail.gmail.com> (raw)
In-Reply-To: <20210330071700.kpjoyp5zlni7uejm@wittgenstein>
On Tue, Mar 30, 2021 at 2:17 PM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
> The only thing that is a bit unpleasant here is that this change
> breaks the consistency between the creation helpers:
>
> do_mkdirat()
> do_symlinkat()
> do_linkat()
> do_mknodat()
>
> All but of them currently take
> const char __user *pathname
> and call
> user_path_create()
> with that do_mkdirat() change that's no longer true. One of the major
> benefits over the recent years in this code is naming and type consistency.
> And since it's just matter of time until io_uring will also gain support
> for do_{symlinkat,linkat,mknodat} I would think switching all of them to
> take a struct filename
> and then have all do_* helpers call getname() might just be nicer in the
> long run.
OK, I can change the rest of them in the next version if no one objects.
--
Dmitry Kadashev
next prev parent reply other threads:[~2021-03-31 10:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 5:59 [PATCH v3 0/2] io_uring: add mkdirat support Dmitry Kadashev
2021-03-30 5:59 ` [PATCH v3 1/2] fs: make do_mkdirat() take struct filename Dmitry Kadashev
2021-03-30 7:17 ` Christian Brauner
2021-03-31 10:43 ` Dmitry Kadashev [this message]
2021-04-08 8:45 ` Dmitry Kadashev
2021-04-15 7:14 ` Dmitry Kadashev
2021-04-15 10:08 ` Christian Brauner
2021-04-15 10:09 ` Christian Brauner
2021-04-15 10:41 ` Dmitry Kadashev
2021-04-15 14:09 ` Christian Brauner
2021-05-13 7:45 ` Dmitry Kadashev
2021-05-14 15:11 ` Christian Brauner
2021-03-30 5:59 ` [PATCH v3 2/2] io_uring: add support for IORING_OP_MKDIRAT Dmitry Kadashev
2021-03-31 1:31 ` Al Viro
2021-03-31 10:38 ` Dmitry Kadashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOKbgA4eAYE1aDBU3WJumnz8aUoF23qOD32F_OtwE=qCXRSxeA@mail.gmail.com' \
--to=dkadashev@gmail.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=christian.brauner@ubuntu.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).