io-uring.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: io-uring@vger.kernel.org, Pavel Emelyanov <xemul@openvz.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Jens Axboe <axboe@kernel.dk>,
	Pavel Begunkov <asml.silence@gmail.com>,
	Lokesh Gidra <lokeshgidra@google.com>,
	Eric Biggers <ebiggers@google.com>,
	Paul Moore <paul@paul-moore.com>,
	Daniel Colascione <dancol@google.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH  1/2] fs: anon_inodes: export anon_inode_getfile_secure helper
Date: Wed, 19 May 2021 17:04:57 +0100	[thread overview]
Message-ID: <YKU3KWn4ZnRSyyFY@infradead.org> (raw)
In-Reply-To: <20210519113058.1979817-2-memxor@gmail.com>

On Wed, May 19, 2021 at 05:00:56PM +0530, Kumar Kartikeya Dwivedi wrote:
> This is the non-fd installing analogue of anon_inode_getfd_secure. In
> addition to allowing LSMs to attach policy to the distinct inode, this
> is also needed for checkpoint restore of an io_uring instance where a
> mapped region needs to mapped back to the io_uring fd by CRIU. This is
> currently not possible as all anon_inodes share a single inode.

No need to export it, as io_uring can't be built modular.

> +struct file *anon_inode_getfile_secure(const char *name,
> +				       const struct file_operations *fops,
> +				       void *priv, int flags,
> +				       const struct inode *context_inode)
> +{
> +	return __anon_inode_getfile(name, fops, priv, flags, context_inode, true);
> +}
> +EXPORT_SYMBOL_GPL(anon_inode_getfile_secure);

Please avoid the overly long line here.


  parent reply	other threads:[~2021-05-19 16:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 11:30 [PATCH 0/2] Create io_uring fd with ephemeral inode Kumar Kartikeya Dwivedi
2021-05-19 11:30 ` [PATCH 1/2] fs: anon_inodes: export anon_inode_getfile_secure helper Kumar Kartikeya Dwivedi
2021-05-19 15:22   ` Paul Moore
2021-05-19 23:07     ` Kumar Kartikeya Dwivedi
2021-05-20  2:29       ` Paul Moore
2021-05-19 16:04   ` Christoph Hellwig [this message]
2021-05-19 11:30 ` [PATCH 2/2] fs: io_uring: convert to use anon_inode_getfile_secure Kumar Kartikeya Dwivedi
2021-05-19 15:18 ` [PATCH 0/2] Create io_uring fd with ephemeral inode Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKU3KWn4ZnRSyyFY@infradead.org \
    --to=hch@infradead.org \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=dancol@google.com \
    --cc=ebiggers@google.com \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshgidra@google.com \
    --cc=memxor@gmail.com \
    --cc=paul@paul-moore.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).