From: Jens Axboe <axboe@kernel.dk>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org, Kanchan Joshi <joshi.k@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>
Subject: Re: [PATCH 2/2] fs: Remove kiocb->ki_complete
Date: Wed, 8 Jul 2020 21:25:03 -0600 [thread overview]
Message-ID: <a0d5c015-1985-280e-2253-8e2663b234e9@kernel.dk> (raw)
In-Reply-To: <20200708222637.23046-3-willy@infradead.org>
On 7/8/20 4:26 PM, Matthew Wilcox (Oracle) wrote:
> +void unregister_kiocb_completion(int id)
> +{
> + ki_cmpls[id - 1] = NULL;
> +}
> +EXPORT_SYMBOL(unregister_kiocb_completion);
This should have a limit check (<= 0 || > max).
> void complete_kiocb(struct kiocb *iocb, long ret, long ret2)
> {
> - iocb->ki_complete(iocb, ret, ret2);
> + unsigned int id = kiocb_completion_id(iocb);
> +
> + if (id > 0)
> + ki_cmpls[id - 1](iocb, ret, ret2);
> }
I'd make id == 0 be a dummy funciton to avoid this branch.
--
Jens Axboe
next prev parent reply other threads:[~2020-07-09 3:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 22:26 [PATCH 0/2] Remove kiocb ki_complete Matthew Wilcox (Oracle)
2020-07-08 22:26 ` [PATCH 1/2] fs: Abstract calling the kiocb completion function Matthew Wilcox (Oracle)
2020-07-08 22:37 ` Jens Axboe
2020-07-08 22:40 ` Matthew Wilcox
2020-07-08 22:50 ` Jens Axboe
2020-07-08 22:26 ` [PATCH 2/2] fs: Remove kiocb->ki_complete Matthew Wilcox (Oracle)
2020-07-08 22:38 ` Jens Axboe
2020-07-09 3:25 ` Jens Axboe [this message]
2020-07-09 5:23 ` kernel test robot
2020-07-08 22:33 ` [PATCH 0/2] Remove kiocb ki_complete Jens Axboe
2020-07-09 10:17 ` Christoph Hellwig
2020-07-09 11:10 ` Matthew Wilcox
2020-07-09 13:26 ` Christoph Hellwig
2020-07-09 13:32 ` Matthew Wilcox
2020-07-09 13:53 ` Jens Axboe
2020-07-09 13:37 ` Pavel Begunkov
2020-07-09 13:43 ` Matthew Wilcox
2020-07-09 13:49 ` Pavel Begunkov
2020-07-09 13:53 ` Matthew Wilcox
2020-07-09 13:59 ` Pavel Begunkov
2020-07-09 13:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0d5c015-1985-280e-2253-8e2663b234e9@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).