From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] io_uring: don't wait when under-submitting
Date: Sat, 14 Dec 2019 11:43:37 -0700 [thread overview]
Message-ID: <a1f0a9ed-085f-dd6f-9038-62d701f4c354@kernel.dk> (raw)
In-Reply-To: <c6f625bdb27ea3b929d0717ebf2aaa33ad5410da.1576335142.git.asml.silence@gmail.com>
On 12/14/19 7:53 AM, Pavel Begunkov wrote:
> There is no reliable way to submit and wait in a single syscall, as
> io_submit_sqes() may under-consume sqes (in case of an early error).
> Then it will wait for not-yet-submitted requests, deadlocking the user
> in most cases.
>
> In such cases adjust min_complete, so it won't wait for more than
> what have been submitted in the current call to io_uring_enter(). It
> may be less than totally in-flight including previous submissions,
> but this shouldn't do harm and up to a user.
Thanks, applied.
--
Jens Axboe
next prev parent reply other threads:[~2019-12-14 18:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 7:51 [PATCH 1/1] io_uring: don't wait when under-submitting Pavel Begunkov
2019-12-13 18:22 ` Jens Axboe
2019-12-13 18:32 ` Jens Axboe
2019-12-13 21:32 ` Pavel Begunkov
2019-12-13 21:48 ` Jens Axboe
2019-12-14 14:31 ` [PATCH v2] " Pavel Begunkov
2019-12-14 14:39 ` Jens Axboe
2019-12-14 14:44 ` Pavel Begunkov
2019-12-14 14:53 ` [PATCH v3] " Pavel Begunkov
2019-12-14 18:43 ` Jens Axboe [this message]
2019-12-15 5:42 ` Jens Axboe
2019-12-15 15:48 ` Pavel Begunkov
2019-12-15 21:33 ` Jens Axboe
2019-12-16 16:31 ` [PATCH v4] " Pavel Begunkov
2019-12-16 16:47 ` [PATCH v3] " Pavel Begunkov
2019-12-16 16:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1f0a9ed-085f-dd6f-9038-62d701f4c354@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).